PERFORCE change 97394 for review

Kip Macy kmacy at FreeBSD.org
Thu May 18 05:52:15 UTC 2006


http://perforce.freebsd.org/chv.cgi?CH=97394

Change 97394 by kmacy at kmacy_storage:sun4v_rwbuf on 2006/05/18 05:51:04

	simplify initial invalidation when setting TSB

Affected files ...

.. //depot/projects/kmacy_sun4v/src/sys/sun4v/sun4v/tsb.c#15 edit

Differences ...

==== //depot/projects/kmacy_sun4v/src/sys/sun4v/sun4v/tsb.c#15 (text+ko) ====

@@ -166,12 +166,11 @@
 	tsb_index = (va >> tsb_shift) & TSB_MASK(tsb);
 	entry = (tte_t *)TLB_PHYS_TO_DIRECT(tsb->hvtsb_pa + 2*tsb_index*sizeof(uint64_t));
 	tte_tag = (ctx << TTARGET_CTX_SHIFT) | (va >> TTARGET_VA_SHIFT);
-	tte_data &= ~VTD_V;
 	/* store new value with valid bit cleared 
 	 * to avoid invalid intermediate value;
 	 */
-	*(entry + 1) = tte_data;
-	tte_data |= VTD_V;
+	*(entry + 1) = 0;
+	membar(StoreLoad);
 	*(entry) = tte_tag;
 	*(entry + 1) = tte_data;
 	membar(Sync);


More information about the p4-projects mailing list