PERFORCE change 98626 for review

[John Birrell]

http://perforce.freebsd.org/chv.cgi?CH=98626

Change 98626 by jb at jb_freebsd2 on 2006/06/06 03:11:29

	Enable most of the remaining safety tests. Some of these fail
	for certain FBT probes which are not safe to be called from a
	DTrace probe context. That's a FBT problem not a problem with the
	DTrace infrastructure or the tests. The tests are just reporting
	it the way it is.
	
	I need to narrow down the functions which appear unsafe when called
	from a DTrace probe context. Needles and hay-stacks. Sigh.

Affected files ...

.. //depot/projects/dtrace/src/cddl/test/dtrace/Makefile#16 edit

Differences ...

==== //depot/projects/dtrace/src/cddl/test/dtrace/Makefile#16 (text+ko) ====

@@ -317,8 +317,7 @@
 	${.CURDIR}/tst/common/dtraceUtil/tst.ZeroFunctionProbes.d.ksh \
 	${.CURDIR}/tst/common/dtraceUtil/tst.ZeroNameProbes.d.ksh \
 	${.CURDIR}/tst/common/dtraceUtil/tst.ZeroProbeIdentfier.d.ksh \
-	${.CURDIR}/tst/common/dtraceUtil/tst.ZeroProbesWithoutZ.d.ksh \
-	${.CURDIR}/tst/common/dtraceUtil/tst.ZeroProviderProbes.d.ksh
+	${.CURDIR}/tst/common/dtraceUtil/tst.ZeroProbesWithoutZ.d.ksh
 
 TESTEND= \
 	${.CURDIR}/tst/common/end/err.D_IDENT_UNDEF.timespent.d \
@@ -646,8 +645,26 @@
 	${.CURDIR}/tst/common/providers/tst.twoprof.d
 
 TESTSAFETY= \
+	${.CURDIR}/tst/common/safety/tst.cleanpath.d \
 	${.CURDIR}/tst/common/safety/tst.copyin.d \
-	${.CURDIR}/tst/common/safety/tst.shortstr.d
+	${.CURDIR}/tst/common/safety/tst.ddi_pathname.d \
+	${.CURDIR}/tst/common/safety/tst.dirname.d \
+	${.CURDIR}/tst/common/safety/tst.index.d \
+	${.CURDIR}/tst/common/safety/tst.null.d \
+	${.CURDIR}/tst/common/safety/tst.progenyof.d \
+	${.CURDIR}/tst/common/safety/tst.random.d \
+	${.CURDIR}/tst/common/safety/tst.shortstr.d \
+	${.CURDIR}/tst/common/safety/tst.stack.d \
+	${.CURDIR}/tst/common/safety/tst.stackdepth.d \
+	${.CURDIR}/tst/common/safety/tst.strchr.d \
+	${.CURDIR}/tst/common/safety/tst.strjoin.d \
+	${.CURDIR}/tst/common/safety/tst.strstr.d \
+	${.CURDIR}/tst/common/safety/tst.strtok.d \
+	${.CURDIR}/tst/common/safety/tst.substr.d \
+	${.CURDIR}/tst/common/safety/tst.unalign.d \
+	${.CURDIR}/tst/common/safety/tst.uregs.d \
+	${.CURDIR}/tst/common/safety/tst.ustack.d \
+	${.CURDIR}/tst/common/safety/tst.ustackdepth.d \
 
 TESTSCALARS= \
 	${.CURDIR}/tst/common/scalars/err.D_ARR_LOCAL.thisarray.d \
@@ -797,6 +814,7 @@
 TESTTRACE= \
 	${.CURDIR}/tst/common/trace/err.D_TRACE_VOID.bad.d \
 	${.CURDIR}/tst/common/trace/err.D_PROTO_LEN.bad.d \
+	${.CURDIR}/tst/common/trace/tst.misc.d \
 	${.CURDIR}/tst/common/trace/tst.qstring.d \
 	${.CURDIR}/tst/common/trace/tst.string.d
 
@@ -1268,6 +1286,9 @@
 	${.CURDIR}/tst/common/profile-n/tst.ufunc.ksh \
 	${.CURDIR}/tst/common/profile-n/tst.umod.ksh \
 	${.CURDIR}/tst/common/profile-n/tst.usym.ksh \
+	${.CURDIR}/tst/common/safety/tst.rw.d \
+	${.CURDIR}/tst/common/safety/tst.vahole.d \
+	${.CURDIR}/tst/common/safety/tst.violentdeath.ksh \
 	${.CURDIR}/tst/common/scalars/tst.selfarray2.d \
 	${.CURDIR}/tst/common/scripting/err.D_MACRO_UNDEF.invalidargs.d \
 	${.CURDIR}/tst/common/scripting/err.D_OP_LVAL.rdonly.d \
@@ -1288,39 +1309,11 @@
 	${.CURDIR}/tst/common/speculation/err.D_ACT_SPEC.SpeculateWithPanic.d \
 	${.CURDIR}/tst/common/speculation/err.D_ACT_SPEC.SpeculateWithRaise.d \
 	${.CURDIR}/tst/common/speculation/err.D_ACT_SPEC.SpeculateWithStop.d \
-	${.CURDIR}/tst/common/trace/tst.misc.d \
-	${.CURDIR}/tst/common/tracemem/err.D_TRACEMEM_ADDR.badaddr.d
+	${.CURDIR}/tst/common/tracemem/err.D_TRACEMEM_ADDR.badaddr.d \
 
 notwork	: ${.CURDIR}/bin/dtest ${NOTWORK}
 	@${.CURDIR}/bin/dtest ${NOTWORK}
 
-REQUIRES_FBT= \
-	${.CURDIR}/tst/common/misc/tst.roch.d \
-	${.CURDIR}/tst/common/predicates/tst.argsnotcached.d \
-	${.CURDIR}/tst/common/safety/tst.cleanpath.d \
-	${.CURDIR}/tst/common/safety/tst.ddi_pathname.d \
-	${.CURDIR}/tst/common/safety/tst.dirname.d \
-	${.CURDIR}/tst/common/safety/tst.index.d \
-	${.CURDIR}/tst/common/safety/tst.msgdsize.d \
-	${.CURDIR}/tst/common/safety/tst.msgsize.d \
-	${.CURDIR}/tst/common/safety/tst.null.d \
-	${.CURDIR}/tst/common/safety/tst.progenyof.d \
-	${.CURDIR}/tst/common/safety/tst.random.d \
-	${.CURDIR}/tst/common/safety/tst.rw.d \
-	${.CURDIR}/tst/common/safety/tst.stack.d \
-	${.CURDIR}/tst/common/safety/tst.stackdepth.d \
-	${.CURDIR}/tst/common/safety/tst.strchr.d \
-	${.CURDIR}/tst/common/safety/tst.strjoin.d \
-	${.CURDIR}/tst/common/safety/tst.strstr.d \
-	${.CURDIR}/tst/common/safety/tst.strtok.d \
-	${.CURDIR}/tst/common/safety/tst.substr.d \
-	${.CURDIR}/tst/common/safety/tst.unalign.d \
-	${.CURDIR}/tst/common/safety/tst.uregs.d \
-	${.CURDIR}/tst/common/safety/tst.ustack.d \
-	${.CURDIR}/tst/common/safety/tst.ustackdepth.d \
-	${.CURDIR}/tst/common/safety/tst.vahole.d \
-	${.CURDIR}/tst/common/safety/tst.violentdeath.ksh
-
 REQUIRES_LIBPROC= \
 	${.CURDIR}/tst/common/vars/tst.ucaller.ksh \
 	${.CURDIR}/tst/common/misc/tst.schrock.ksh
@@ -1358,10 +1351,14 @@
 	${.CURDIR}/tst/common/funcs/tst.mutex_owner.d \
 	${.CURDIR}/tst/common/funcs/tst.mutex_type_adaptive.d \
 	${.CURDIR}/tst/common/misc/tst.include.ksh \
+	${.CURDIR}/tst/common/misc/tst.roch.d \
+	${.CURDIR}/tst/common/predicates/tst.argsnotcached.d \
 	${.CURDIR}/tst/common/predicates/tst.predcache.ksh \
 	${.CURDIR}/tst/common/preprocessor/err.D_PRAGCTL_INVAL.tabdefine.d \
 	${.CURDIR}/tst/common/printf/tst.sym.d \
 	${.CURDIR}/tst/common/probes/tst.probestar.d \
+	${.CURDIR}/tst/common/safety/tst.msgdsize.d \
+	${.CURDIR}/tst/common/safety/tst.msgsize.d \
 	${.CURDIR}/tst/common/tracemem/tst.rootvp.d \
 	${.CURDIR}/tst/common/types/tst.complex.d \
 	${.CURDIR}/tst/common/types/tst.struct.d \
@@ -1377,6 +1374,7 @@
 	${.CURDIR}/tst/common/dtraceUtil/tst.DestructWithName.d.ksh \
 	${.CURDIR}/tst/common/dtraceUtil/tst.DestructWithProvider.d.ksh \
 	${.CURDIR}/tst/common/dtraceUtil/tst.ZeroModuleProbes.d.ksh \
+	${.CURDIR}/tst/common/dtraceUtil/tst.ZeroProviderProbes.d.ksh \
 	${.CURDIR}/tst/common/funcs/tst.chill.ksh \
 	${.CURDIR}/tst/common/inline/tst.InlineKinds.d \
 	${.CURDIR}/tst/common/printa/tst.stack.d \