PERFORCE change 111629 for review

Paolo Pisati piso at FreeBSD.org
Wed Dec 13 04:43:30 PST 2006


http://perforce.freebsd.org/chv.cgi?CH=111629

Change 111629 by piso at piso_newluxor on 2006/12/13 12:43:14

	Comment out a check about FAST only handlers: with filters
	it shouldn't be a problem anymore.

Affected files ...

.. //depot/projects/soc2006/intr_filter/arm/at91/at91.c#6 edit

Differences ...

==== //depot/projects/soc2006/intr_filter/arm/at91/at91.c#6 (text) ====

@@ -548,9 +548,15 @@
 {
 	struct at91_softc *sc = device_get_softc(dev);
 
-	if (rman_get_start(ires) == AT91RM92_IRQ_SYSTEM && 
-	    !IS_FAST(filter, intr))
-		panic("All system interrupt ISRs must be type INTR_FAST");
+	/*
+	 * XXX mixing FAST and non FAST handlers on arm was a pain
+	 * XXX due to latency, so this check was put here: with
+	 * XXX filters these problems should be resolved, so comment
+	 * XXX out this part but keep it here as a remainder.
+	 * if (rman_get_start(ires) == AT91RM92_IRQ_SYSTEM && 
+	 *   !IS_FAST(filter, intr))
+	 *	panic("All system interrupt ISRs must be type INTR_FAST");
+	 */
 	BUS_SETUP_INTR(device_get_parent(dev), child, ires, flags, filter, intr, 
 	    arg, cookiep);
 	bus_space_write_4(sc->sc_st, sc->sc_sys_sh, IC_IECR,


More information about the p4-projects mailing list