PERFORCE change 111582 for review

Bernd Walter ticso at FreeBSD.org
Tue Dec 12 15:55:04 PST 2006


http://perforce.freebsd.org/chv.cgi?CH=111582

Change 111582 by ticso at ticso on 2006/12/12 23:53:26

	fix a race in transmit buffer handling

Affected files ...

.. //depot/projects/arm/src/sys/arm/at91/if_ate.c#67 edit

Differences ...

==== //depot/projects/arm/src/sys/arm/at91/if_ate.c#67 (text+ko) ====

@@ -72,7 +72,7 @@
 
 #include "miibus_if.h"
 
-#define ATE_MAX_TX_BUFFERS 64		/* We have ping-pong tx buffers */
+#define ATE_MAX_TX_BUFFERS 2		/* We have ping-pong tx buffers */
 #define ATE_MAX_RX_BUFFERS 64
 
 struct ate_softc
@@ -833,6 +833,9 @@
 		 */
 		BPF_MTAP(ifp, m);
 
+		if (sc->sent_mbuf[sc->txcur] != 0) {
+			panic("ate: sc->sent_mbuf[%i] != 0", sc->txcur);
+		}
 		sc->sent_mbuf[sc->txcur] = m;
 		sc->txcur++;
 	}


More information about the p4-projects mailing list