PERFORCE change 111365 for review
Warner Losh
imp at FreeBSD.org
Sat Dec 9 20:35:29 PST 2006
http://perforce.freebsd.org/chv.cgi?CH=111365
Change 111365 by imp at imp_lighthouse on 2006/12/10 04:35:08
We don't need the check against phy == 0. This appears to be
a remant of a time when things were either borked, or a cut-n-paste
job. It is unclear, but also unnecessary.
Remove DELAY. It is also unnecessary. This should help in network
performance a little, since this steals about ~4 * 30us each
second.
Affected files ...
.. //depot/projects/arm/src/sys/arm/at91/if_ate.c#63 edit
Differences ...
==== //depot/projects/arm/src/sys/arm/at91/if_ate.c#63 (text+ko) ====
@@ -988,11 +988,7 @@
* XXX if we implement agressive power savings, then we need
* XXX to make sure that the clock to the emac is on here
*/
-
- if (phy != 0)
- return (0xffff);
sc = device_get_softc(dev);
- DELAY(1); /* Hangs w/o this delay really 30.5us atm */
WR4(sc, ETH_MAN, ETH_MAN_REG_RD(phy, reg));
while ((RD4(sc, ETH_SR) & ETH_SR_IDLE) == 0)
continue;
More information about the p4-projects
mailing list