PERFORCE change 105328 for review

[Hans Petter Selasky]

http://perforce.freebsd.org/chv.cgi?CH=105328

Change 105328 by hselasky at hselasky_mini_itx on 2006/08/30 14:04:20

	Make network drivers smarter by polling status before
	checking it, instead of after.

Affected files ...

.. //depot/projects/usb/src/sys/dev/usb/if_aue.c#7 edit
.. //depot/projects/usb/src/sys/dev/usb/if_axe.c#6 edit
.. //depot/projects/usb/src/sys/dev/usb/if_rue.c#5 edit
.. //depot/projects/usb/src/sys/dev/usb/if_udav.c#5 edit

Differences ...

==== //depot/projects/usb/src/sys/dev/usb/if_aue.c#7 (text+ko) ====

@@ -1339,14 +1339,14 @@
 
 	mii_tick(mii);
 
+	mii_pollstat(mii);
+
 	if ((sc->sc_flags & AUE_FLAG_WAIT_LINK) &&
 	    (mii->mii_media_status & IFM_ACTIVE) &&
 	    (IFM_SUBTYPE(mii->mii_media_active) != IFM_NONE)) {
 	    sc->sc_flags &= ~AUE_FLAG_WAIT_LINK;
 	}
 
-	mii_pollstat(mii);
-
 	sc->sc_media_active = mii->mii_media_active;
 	sc->sc_media_status = mii->mii_media_status;
 

==== //depot/projects/usb/src/sys/dev/usb/if_axe.c#6 (text+ko) ====

@@ -1058,14 +1058,14 @@
 
 	mii_tick(mii);
 
+	mii_pollstat(mii);
+
 	if ((sc->sc_flags & AXE_FLAG_WAIT_LINK) &&
 	    (mii->mii_media_status & IFM_ACTIVE) &&
 	    (IFM_SUBTYPE(mii->mii_media_active) != IFM_NONE)) {
 	    sc->sc_flags &= ~AXE_FLAG_WAIT_LINK;
 	}
 
-	mii_pollstat(mii);
-
 	sc->sc_media_active = mii->mii_media_active;
 	sc->sc_media_status = mii->mii_media_status;
 
@@ -1287,9 +1287,6 @@
 }
 
 /*
- * Stop the adapter and free any mbufs allocated to the
- * RX and TX lists.
- *
  * NOTE: can be called when "ifp" is NULL
  */
 static void

==== //depot/projects/usb/src/sys/dev/usb/if_rue.c#5 (text+ko) ====

@@ -1195,14 +1195,14 @@
 
 	mii_tick(mii);
 
+	mii_pollstat(mii);
+
 	if ((sc->sc_flags & RUE_FLAG_WAIT_LINK) &&
 	    (mii->mii_media_status & IFM_ACTIVE) &&
 	    (IFM_SUBTYPE(mii->mii_media_active) != IFM_NONE)) {
 	    sc->sc_flags &= ~RUE_FLAG_WAIT_LINK;
 	}
 
-	mii_pollstat(mii);
-
 	sc->sc_media_active = mii->mii_media_active;
 	sc->sc_media_status = mii->mii_media_status;
 

==== //depot/projects/usb/src/sys/dev/usb/if_udav.c#5 (text+ko) ====

@@ -1373,14 +1373,14 @@
 
 	mii_tick(mii);
 
+	mii_pollstat(mii);
+
 	if ((sc->sc_flags & UDAV_FLAG_WAIT_LINK) &&
 	    (mii->mii_media_status & IFM_ACTIVE) &&
 	    (IFM_SUBTYPE(mii->mii_media_active) != IFM_NONE)) {
 	    sc->sc_flags &= ~UDAV_FLAG_WAIT_LINK;
 	}
 
-	mii_pollstat(mii);
-
 	sc->sc_media_active = mii->mii_media_active;
 	sc->sc_media_status = mii->mii_media_status;