PERFORCE change 104030 for review

Roman Divacky rdivacky at FreeBSD.org
Tue Aug 15 14:17:36 UTC 2006


http://perforce.freebsd.org/chv.cgi?CH=104030

Change 104030 by rdivacky at rdivacky_witten on 2006/08/15 14:16:35

	Remove the crit section in futex_atomic_op(). The operations should be atomic
	itself and using crit section blows up in a case of page fault.
	
	Pointed out by: jhb

Affected files ...

.. //depot/projects/soc2006/rdivacky_linuxolator/compat/linux/linux_futex.c#25 edit

Differences ...

==== //depot/projects/soc2006/rdivacky_linuxolator/compat/linux/linux_futex.c#25 (text+ko) ====

@@ -448,8 +448,6 @@
 #endif
 	/* XXX: linux verifies access here and returns EFAULT */
 
-	critical_enter();
-
 	switch (op) {
 	   	case FUTEX_OP_SET:
 		   	ret = futex_xchgl(oparg, uaddr, &oldval);
@@ -470,8 +468,6 @@
 			ret = -ENOSYS;
 	}
 
-	critical_exit();
-
 	if (!ret)
 	   	switch (cmp) {
 		      case FUTEX_OP_CMP_EQ: 


More information about the p4-projects mailing list