PERFORCE change 103832 for review

[Roman Divacky]

http://perforce.freebsd.org/chv.cgi?CH=103832

Change 103832 by rdivacky at rdivacky_witten on 2006/08/14 12:28:36

	Attempt to be more style compliant. Some obsolete XXX comments removal, some new comments
	added.

Affected files ...

.. //depot/projects/soc2006/rdivacky_linuxolator/compat/linux/linux_emul.c#3 edit
.. //depot/projects/soc2006/rdivacky_linuxolator/compat/linux/linux_futex.c#22 edit
.. //depot/projects/soc2006/rdivacky_linuxolator/compat/linux/linux_time.c#6 edit
.. //depot/projects/soc2006/rdivacky_linuxolator/i386/linux/linux_machdep.c#48 edit

Differences ...

==== //depot/projects/soc2006/rdivacky_linuxolator/compat/linux/linux_emul.c#3 (text+ko) ====

@@ -77,7 +77,6 @@
 	struct linux_emuldata *em, *p_em;
 	struct proc *p;
 
-	/* XXX: locking? */
 	if (child != 0) {
 	   	/* non-exec call */
    		MALLOC(em, struct linux_emuldata *, sizeof *em, M_LINUX, M_WAITOK | M_ZERO);
@@ -176,7 +175,6 @@
 	   	struct linux_sys_futex_args cup;
 		int null = 0;
 
-		/* XXX: doesnt futex use the addr? */
 		error = copyout(&null, child_clear_tid, sizeof(null));
 		if (error)
 		   	return;

==== //depot/projects/soc2006/rdivacky_linuxolator/compat/linux/linux_futex.c#22 (text+ko) ====

@@ -32,7 +32,9 @@
  */
 
 #include <sys/cdefs.h>
-/* __KERNEL_RCSID(1, "$NetBSD: linux_futex.c,v 1.5 2005/11/23 16:14:57 manu Exp $"); */
+#if 0
+ __KERNEL_RCSID(1, "$NetBSD: linux_futex.c,v 1.5 2005/11/23 16:14:57 manu Exp $");
+#endif
 
 #include "opt_compat.h"
 
@@ -157,7 +159,7 @@
                  * make sure we do not turn it into an infinite
                  * timeout because timeout_hz gets null.
                  *
-                 * We use a minimal timeout of 1/hz. Mayve it would
+                 * We use a minimal timeout of 1/hz. Maybe it would
                  * make sense to just return ETIMEDOUT without sleeping.
                  */
                 if (((timeout.tv_sec != 0) || (timeout.tv_nsec != 0)) &&
@@ -273,10 +275,13 @@
 		f = futex_get(args->uaddr, FUTEX_UNLOCKED);
 		f2 = futex_get(args->uaddr2, FUTEX_UNLOCKED);
 
+		/* This function returns positive number as results
+		 * and negative as errors
+		 */
 		op_ret = futex_atomic_op(td, args->val3, args->uaddr2);
 		if (op_ret < 0) {
 
-		   	/* XXX: ? */
+		   	/* XXX: we dont handle the EFAULT yet */
 		   	if (op_ret != -EFAULT) {
 			   	futex_put(f);
 			   	futex_put(f2);

==== //depot/projects/soc2006/rdivacky_linuxolator/compat/linux/linux_time.c#6 (text+ko) ====

@@ -37,7 +37,9 @@
  */
 
 #include <sys/cdefs.h>
-/*__KERNEL_RCSID(0, "$NetBSD: linux_time.c,v 1.14 2006/05/14 03:40:54 christos Exp $");*/
+#if 0
+__KERNEL_RCSID(0, "$NetBSD: linux_time.c,v 1.14 2006/05/14 03:40:54 christos Exp $");
+#endif
 
 #include "opt_compat.h"
 

==== //depot/projects/soc2006/rdivacky_linuxolator/i386/linux/linux_machdep.c#48 (text+ko) ====

@@ -367,7 +367,6 @@
 	if (!(args->flags & CLONE_FILES))
 		ff |= RFFDG;
 
-
 	/*
 	 * Attempt to detect when linux_clone(2) is used for creating
 	 * kernel threads. Unfortunately despite the existence of the
@@ -410,8 +409,10 @@
 	   	printf("linux_clone: CLONE_PARENT\n");
 	   	
 	if (args->flags & CLONE_THREAD) {
-	 //  	p2->p_pgrp = td->td_proc->p_pgrp;
-	 //	p2->p_pptr = td->td_proc->p_pptr;
+#ifdef notyet
+	   	p2->p_pgrp = td->td_proc->p_pgrp;
+	 	p2->p_pptr = td->td_proc->p_pptr;
+#endif
 	 	exit_signal = 0;
 	   	printf("linux_clone: CLONE_THREADS\n");
 	}