PERFORCE change 71905 for review

David Xu davidxu at FreeBSD.org
Sat Feb 26 13:13:55 GMT 2005


http://perforce.freebsd.org/chv.cgi?CH=71905

Change 71905 by davidxu at davidxu_tiger on 2005/02/26 13:13:34

	Update comments.

Affected files ...

.. //depot/projects/davidxu_thread/src/lib/libthread/arch/alpha/include/pthread_md.h#6 edit
.. //depot/projects/davidxu_thread/src/lib/libthread/arch/amd64/include/pthread_md.h#6 edit
.. //depot/projects/davidxu_thread/src/lib/libthread/arch/i386/include/pthread_md.h#5 edit
.. //depot/projects/davidxu_thread/src/lib/libthread/arch/ia64/include/pthread_md.h#7 edit
.. //depot/projects/davidxu_thread/src/lib/libthread/arch/powerpc/include/pthread_md.h#4 edit
.. //depot/projects/davidxu_thread/src/lib/libthread/arch/sparc64/include/pthread_md.h#6 edit

Differences ...

==== //depot/projects/davidxu_thread/src/lib/libthread/arch/alpha/include/pthread_md.h#6 (text+ko) ====

@@ -34,6 +34,10 @@
 
 #define	DTV_OFFSET		offsetof(struct tcb, tcb_dtv)
 
+/*
+ * Variant I tcb. The structure layout is fixed, don't blindly
+ * change it!
+ */
 struct tcb {
 	void			*tcb_dtv;
 	struct pthread		*tcb_thread;

==== //depot/projects/davidxu_thread/src/lib/libthread/arch/amd64/include/pthread_md.h#6 (text+ko) ====

@@ -44,14 +44,14 @@
 struct tdv;
 
 /*
- * %fs points to a struct tcb.
+ * Variant II tcb, first two members are required by rtld,
+ * %fs points to the structure.
  */
-
 struct tcb {
 	struct tcb		*tcb_self;	/* required by rtld */
 	void			*tcb_dtv;	/* required by rtld */
 	struct pthread		*tcb_thread;
-	void			*tcb_spare[1];	/* align tcb_tmbx to 16 bytes */
+	void			*tcb_spare[1];
 };
 
 /*

==== //depot/projects/davidxu_thread/src/lib/libthread/arch/i386/include/pthread_md.h#5 (text+ko) ====

@@ -41,7 +41,8 @@
 struct pthread;
 
 /*
- * %gs points to a struct tcb.
+ * Variant II tcb, first two members are required by rtld,
+ * %gs points to the structure.
  */
 struct tcb {
 	struct tcb		*tcb_self;	/* required by rtld */

==== //depot/projects/davidxu_thread/src/lib/libthread/arch/ia64/include/pthread_md.h#7 (text+ko) ====

@@ -33,6 +33,10 @@
 
 #define	DTV_OFFSET		offsetof(struct tcb, tcb_dtv)
 
+/*
+ * Variant I tcb. The structure layout is fixed, don't blindly
+ * change it!
+ */
 struct tcb {
 	void			*tcb_dtv;
 	struct pthread		*tcb_thread;

==== //depot/projects/davidxu_thread/src/lib/libthread/arch/powerpc/include/pthread_md.h#4 (text+ko) ====

@@ -39,11 +39,10 @@
 #define	DTV_OFFSET		offsetof(struct tcb, tcb_dtv)
 
 /*
- * %r2 points to end of struct tcb. Variant I tls, the
- * tcb structure layout is fixed, totally 8 bytes on 32 bits
- * machine, don't change it.
+ * Variant I tcb. The structure layout is fixed, don't blindly
+ * change it.
+ * %r2 points to end of the structure.
  */
-
 struct tcb {
 	void			*tcb_dtv;
 	struct pthread		*tcb_thread;

==== //depot/projects/davidxu_thread/src/lib/libthread/arch/sparc64/include/pthread_md.h#6 (text+ko) ====

@@ -39,10 +39,15 @@
 
 struct pthread;
 
+/*
+ * Variant II tcb, first two members are required by rtld.
+ * %g7 points to the structure.
+ */
 struct tcb {
 	struct tcb              *tcb_self;	/* required by rtld */
 	void                    *tcb_dtv;	/* required by rtld */
 	struct pthread          *tcb_thread;	/* our hook */
+	void			*tcb_spare[1];
 };
 
 register struct tcb *_tp __asm("%g7");


More information about the p4-projects mailing list