PERFORCE change 82492 for review

soc-cjones soc-cjones at FreeBSD.org
Wed Aug 24 09:46:35 GMT 2005


http://perforce.freebsd.org/chv.cgi?CH=82492

Change 82492 by soc-cjones at soc-cjones_ishtar on 2005/08/24 09:45:41

	Getting closer!  Now it dies because the topology becomes inconsistent, while saving config.  Looks like g_attach doesn't like it, problem's probably somewhere to be found via redo_rank.

Affected files ...

.. //depot/projects/soc2005/gvinum/src/sys/geom/vinum/geom_vinum_move.c#12 edit

Differences ...

==== //depot/projects/soc2005/gvinum/src/sys/geom/vinum/geom_vinum_move.c#12 (text+ko) ====

@@ -262,6 +262,7 @@
 	printf("gv_move_sd: gv_drive_modify(d)\n");
 	printf("cp=%p, newsd=%p, newsd->provider=%p\n", cp, newsd, newsd->provider);
 	/* And reconnect the consumer ... */
+	newsd->consumer = cp;
 	err = g_attach(cp, newsd->provider);
 	printf("gv_move_sd: called g_attach(%p, %p) => %d; new consumer %p\n", cp, newsd->provider, err, newsd->consumer);
 	if (err) {
@@ -271,6 +272,7 @@
 	} else {
 		printf("gv_move_sd: set newsd->consumer to %p\n", newsd->consumer);
 	}
+	newsd->consumer = cp;
 	printf("gv_move_sd: before LIST_INSERT_HEAD\n");
 	LIST_INSERT_HEAD(&sc->subdisks, newsd, sd);
 	printf("gv_move_sd: inserted newsd into subdisks list\n");


More information about the p4-projects mailing list