PERFORCE change 33663 for review

John Baldwin jhb at FreeBSD.org
Thu Jun 26 10:57:29 PDT 2003


On 25-Jun-2003 Peter Wemm wrote:
> http://perforce.freebsd.org/chv.cgi?CH=33663
> 
> Change 33663 by peter at peter_hammer on 2003/06/25 15:05:09
> 
>       Port sym to amd64

This is possibly not correct.  Do all hammer's support the P3+
SFENCE and related instructions?  Even i386 should probably be
using what bus_space_barrier() uses.  Heck, sym should probably
just be using bus_space_barrier anyways.

> Affected files ...
> 
> .. //depot/projects/hammer/sys/dev/sym/sym_hipd.c#6 edit
> 
> Differences ...
> 
> ==== //depot/projects/hammer/sys/dev/sym/sym_hipd.c#6 (text+ko) ====
> 
> @@ -162,7 +162,7 @@
>   *  make sense) to be used.
>   */
>  
> -#if  defined __i386__
> +#if  defined __i386__ || defined __amd64__
>  #define MEMORY_BARRIER()     do { ; } while(0)
>  #elif        defined __alpha__
>  #define MEMORY_BARRIER()     alpha_mb()

-- 

John Baldwin <jhb at FreeBSD.org>  <><  http://www.FreeBSD.org/~jhb/
"Power Users Use the Power to Serve!"  -  http://www.FreeBSD.org/


More information about the p4-projects mailing list