PERFORCE change 35027 for review

Marcel Moolenaar marcel at FreeBSD.org
Sat Jul 26 00:21:48 PDT 2003


http://perforce.freebsd.org/chv.cgi?CH=35027

Change 35027 by marcel at marcel_nfs on 2003/07/26 00:21:06

	Move uart_debug() to uart_core.c. It's useful enough to
	keep and the sloppy implementation is causing a build
	failure.

Affected files ...

.. //depot/projects/uart/dev/uart/uart_bus.h#8 edit
.. //depot/projects/uart/dev/uart/uart_core.c#8 edit

Differences ...

==== //depot/projects/uart/dev/uart/uart_bus.h#8 (text+ko) ====

@@ -30,7 +30,6 @@
 #define _DEV_UART_BUS_H_
 
 #include <sys/systm.h>
-#include <machine/stdarg.h>
 
 /* Drain and flush targets. */
 #define	UART_DRAIN_RECEIVER	0x0001
@@ -114,18 +113,7 @@
 int uart_tty_detach(struct uart_softc *);
 void uart_tty_intr(void *arg);
 
-static __inline void
-uart_debug(struct uart_softc *sc, const char *fmt, ...)
-{
-#if defined(UART_DEBUG) || 1
-	va_list ap;
-	va_start(ap, fmt);
-	if (sc != NULL)
-		device_print_prettyname(sc->sc_dev);
-	vprintf(fmt, ap);
-	va_end(ap);
-#endif
-}
+void uart_debug(struct uart_softc *, const char *, ...);
 
 /*
  * Receive buffer operations.

==== //depot/projects/uart/dev/uart/uart_core.c#8 (text+ko) ====

@@ -41,6 +41,7 @@
 #include <sys/termios.h>
 #include <sys/tty.h>
 #include <machine/resource.h>
+#include <machine/stdarg.h>
 
 #include <dev/uart/uart.h>
 #include <dev/uart/uart_bus.h>
@@ -70,6 +71,19 @@
 	.d_kqfilter = ttykqfilter,
 };
 
+void
+uart_debug(struct uart_softc *sc, const char *fmt, ...)
+{
+#if defined(UART_DEBUG) || 1
+	va_list ap;
+	va_start(ap, fmt);
+	if (sc != NULL)
+		device_print_prettyname(sc->sc_dev);
+	vprintf(fmt, ap);
+	va_end(ap);
+#endif
+}
+
 static void
 uart_tty_oproc(struct tty *tp)
 {


More information about the p4-projects mailing list