PERFORCE change 43768 for review

Peter Wemm peter at FreeBSD.org
Wed Dec 10 13:37:23 PST 2003


http://perforce.freebsd.org/chv.cgi?CH=43768

Change 43768 by peter at peter_daintree on 2003/12/10 13:36:21

	correct the placement of some comments.

Affected files ...

.. //depot/projects/hammer/sys/compat/freebsd32/syscalls.master#4 edit

Differences ...

==== //depot/projects/hammer/sys/compat/freebsd32/syscalls.master#4 (text+ko) ====

@@ -1,36 +1,5 @@
  $FreeBSD: src/sys/compat/freebsd32/syscalls.master,v 1.26 2003/11/08 07:31:30 peter Exp $
-;	from: @(#)syscalls.master	8.2 (Berkeley) 1/13/94
-;	from: src/sys/kern/syscalls.master 1.107
-;
-; System call name/number master file.
-; Processed to created init_sysent.c, syscalls.c and syscall.h.
-
-; Columns: number [M]type nargs namespc name alt{name,tag,rtyp}/comments
-;	number	system call number, must be in order
-;	type	one of [M]STD, [M]OBSOL, [M]UNIMPL, [M]COMPAT, [M]CPT_NOA,
-;		[M]LIBCOMPAT, [M]NODEF,  [M]NOARGS,  [M]NOPROTO,  [M]NOIMPL,
-;		[M]NOSTD
-;	namespc one of POSIX, BSD, NOHIDE
-;	name	psuedo-prototype of syscall routine
-;		If one of the following alts is different, then all appear:
-;	altname	name of system call if different
-;	alttag	name of args struct tag if different from [o]`name'"_args"
-;	altrtyp	return type if not int (bogus - syscalls always return int)
-;		for UNIMPL/OBSOL, name continues with comments
 
-; types:
-;	[M]	e.g. like MSTD -- means the system call is MP-safe.  If no
-;		M prefix is used, the syscall wrapper will obtain the Giant
-;		lock for the syscall.
-;	STD	always included
-;	COMPAT	included on COMPAT #ifdef
-;	LIBCOMPAT included on COMPAT #ifdef, and placed in syscall.h
-;	OBSOL	obsolete, not included in system, only specifies name
-;	UNIMPL	not implemented, placeholder only
-;	NOSTD	implemented but as a lkm that can be statically
-;			compiled in sysent entry will be filled with lkmsys
-;			so the SYSCALL_MODULE macro works
-
 ; #ifdef's, etc. may be included, and are copied to the output files.
 
 #include <sys/param.h>
@@ -52,9 +21,6 @@
 3	MNOPROTO POSIX	{ ssize_t read(int fd, void *buf, size_t nbyte); }
 4	MNOPROTO POSIX	{ ssize_t write(int fd, const void *buf, size_t nbyte); }
 5	STD	POSIX	{ int freebsd32_open(char *path, int flags, int mode); }
-; XXX should be		{ int open(const char *path, int flags, ...); }
-; but we're not ready for `const' or varargs.
-; XXX man page says `mode_t mode'.
 6	MNOPROTO POSIX	{ int close(int fd); }
 7	MSTD BSD	{ int freebsd32_wait4(int pid, int *status, int options, \
 			    struct rusage32 *rusage); }
@@ -74,7 +40,6 @@
 20	MNOPROTO POSIX	{ pid_t getpid(void); }
 21	NOPROTO	BSD	{ int mount(char *type, char *path, int flags, \
 			    caddr_t data); }
-; XXX `path' should have type `const char *' but we're not ready for that.
 22	NOPROTO	BSD	{ int unmount(char *path, int flags); }
 23	MNOPROTO POSIX	{ int setuid(uid_t uid); }
 24	MNOPROTO POSIX	{ uid_t getuid(void); }
@@ -83,6 +48,7 @@
 			    int data); }
 ; XXX implement
 27	UNIMPL	BSD	recvmsg
+; XXX implement - this is wrong, the iovec isn't compatable
 28	MNOPROTO BSD	{ int sendmsg(int s, caddr_t msg, int flags); }
 29	MNOPROTO BSD	{ int recvfrom(int s, caddr_t buf, size_t len, \
 			    int flags, caddr_t from, int *fromlenaddr); }
@@ -160,12 +126,9 @@
 90	MNOPROTO POSIX	{ int dup2(u_int from, u_int to); }
 91	UNIMPL	BSD	getdopt
 92	MNOPROTO POSIX	{ int fcntl(int fd, int cmd, long arg); }
-; XXX should be		{ int fcntl(int fd, int cmd, ...); }
-; but we're not ready for varargs.
-; XXX man page says `int arg' too.
+; XXX need to override for big-endian - little-endian should work fine.
 93	STD	BSD	{ int freebsd32_select(int nd, fd_set *in, fd_set *ou, \
 			    fd_set *ex, struct timeval32 *tv); }
-; XXX need to override for big-endian - little-endian should work fine.
 94	UNIMPL	BSD	setdopt
 95	NOPROTO	POSIX	{ int fsync(int fd); }
 96	MNOPROTO BSD	{ int setpriority(int which, int who, int prio); }
@@ -272,6 +235,7 @@
 171	STD	BSD	{ int freebsd32_shmsys(int which, int a2, int a3, \
 			    int a4); }
 172	UNIMPL	NOHIDE	nosys
+; XXX note - bigendian is different
 173	STD POSIX	{ ssize_t freebsd32_pread(int fd, void *buf, \
 			    size_t nbyte, int pad, u_int32_t offsetlo, \
 			    u_int32_t offsethi); }
@@ -279,7 +243,6 @@
 174	STD	POSIX	{ ssize_t freebsd32_pwrite(int fd, const void *buf, \
 			    size_t nbyte, int pad, u_int32_t offsetlo, \
 			    u_int32_t offsethi); }
-; XXX note - bigendian is different
 175	UNIMPL	NOHIDE	nosys
 176	MNOPROTO BSD	{ int ntp_adjtime(struct timex *tp); }
 177	UNIMPL	NOHIDE	sfork (BSD/OS 2.x)


More information about the p4-projects mailing list