PERFORCE change 43329 for review

Brian F. Feldman green at FreeBSD.org
Wed Dec 3 16:22:44 PST 2003


Peter Wemm <peter at FreeBSD.org> wrote:
> http://perforce.freebsd.org/chv.cgi?CH=43329
> 
> Change 43329 by peter at peter_overcee on 2003/12/02 17:12:26
> 
> 	grrr. this is totally broken if you have a serial console
> 	attached and as the primary console, as it prevents ddb
> 	starting up if you crash while running X on the syscons
> 	console.

How about we change them all to do something like this?  Yes, I'm aware that 
it contains levels of bogosity.  I'd actually rather change 
consdev::cn_flags to have a flag for CN_FLAG_UNAVAIL, and then cnunavail() 
would be easier to call "correctish".

(tty_cons.c)
int
cnunavail(void)
{
	struct cn_device *cnd;

	cnd = STAILQ_FIRST(&cn_devlist);
	return (cnd == NULL || (cons_unavail && 
	    bcmp(cnd->cn_name, "ttyv", 4) == 0));
}

-- 
Brian Fundakowski Feldman                           \'[ FreeBSD ]''''''''''\
  <> green at FreeBSD.org                               \  The Power to Serve! \
 Opinions expressed are my own.                       \,,,,,,,,,,,,,,,,,,,,,,\




More information about the p4-projects mailing list