PERFORCE change 37180 for review

Chris Vance cvance at FreeBSD.org
Fri Aug 29 08:22:21 PDT 2003


http://perforce.freebsd.org/chv.cgi?CH=37180

Change 37180 by cvance at cvance_korben on 2003/08/29 08:21:42

	Fix comma bug -- when we unwind, 'first' was incorrect.

Affected files ...

.. //depot/projects/trustedbsd/mac/sys/kern/kern_mac.c#408 edit

Differences ...

==== //depot/projects/trustedbsd/mac/sys/kern/kern_mac.c#408 (text+ko) ====

@@ -459,10 +459,9 @@
 		 } else							\
 			ignorenotfound = 0;				\
 		savedlen = sbuf_len(&sb);				\
-		if (first) {						\
+		if (first)						\
 			error = sbuf_printf(&sb, "%s/", element_name);	\
-			first = 0;					\
-		} else							\
+		else							\
 			error = sbuf_printf(&sb, ",%s/", element_name);	\
 		if (error == -1) {					\
 			error = EINVAL;	/* XXX: E2BIG? */		\
@@ -479,6 +478,8 @@
 		} else if (claimed != 1) {				\
 			error = EINVAL;	/* XXX: ENOLABEL? */		\
 			break;						\
+		} else {						\
+			first = 0;					\
 		}							\
 	}								\
 	sbuf_finish(&sb);						\


More information about the p4-projects mailing list