PERFORCE change 35749 for review
Sam Leffler
sam at errno.com
Fri Aug 8 12:26:37 PDT 2003
> On 07-Aug-2003 Sam Leffler wrote:
>> http://perforce.freebsd.org/chv.cgi?CH=35749
>>
>> Change 35749 by sam at sam_ebb on 2003/08/07 15:29:55
>>
>> o must unlock before destroying mutex
>> o must lock rt_gwroute before freeing when cleaning up on error
>
> It's ok to own a mutex when you destroy it. It's actually fairly
> desirable in fact since it is a rather foolproof way of making sure
> someone else doesn't own it. Of course, they could still be blocked on
> it.. :-/
That's what I thought and was counting on, but I was getting crashes in the
mutex code trying to clear the sleep list. Unlocking first fixed it (and I
looked around and saw some other code doing it too--I think). I'll add it
to my TODO list to look at.
Sam
More information about the p4-projects
mailing list