drm-i915-hw-context.7.patch

Lundberg, Johannes johannes at brilliantservice.co.jp
Sat Sep 13 12:23:54 UTC 2014


The reason I ask is because I get these errors with the latest patch (nr 7)

/usr/src/sys/modules/drm2/i915kms/../../../dev/drm2/i915/i915_gem_context.c:653:12:
error: redefinition of 'get_context_size'
static int get_context_size(struct drm_device *dev)
           ^
/usr/src/sys/modules/drm2/i915kms/../../../dev/drm2/i915/i915_gem_context.c:107:12:
note: previous definition is here
static int get_context_size(struct drm_device *dev)
           ^
/usr/src/sys/modules/drm2/i915kms/../../../dev/drm2/i915/i915_gem_context.c:681:13:
error: redefinition of 'do_destroy'
static void do_destroy(struct i915_hw_context *ctx)
            ^
/usr/src/sys/modules/drm2/i915kms/../../../dev/drm2/i915/i915_gem_context.c:135:13:
note: previous definition is here
static void do_destroy(struct i915_hw_context *ctx)
            ^
/usr/src/sys/modules/drm2/i915kms/../../../dev/drm2/i915/i915_gem_context.c:699:1:
error: redefinition of 'create_hw_context'
create_hw_context(struct drm_device *dev,
^
/usr/src/sys/modules/drm2/i915kms/../../../dev/drm2/i915/i915_gem_context.c:153:1:
note: previous definition is here
create_hw_context(struct drm_device *dev,
^
/usr/src/sys/modules/drm2/i915kms/../../../dev/drm2/i915/i915_gem_context.c:753:20:
error: redefinition of 'is_default_context'
static inline bool is_default_context(struct i915_hw_context *ctx)
                   ^
--- db_break.o ---
ctfconvert -L VERSION -g db_break.o
--- modules-all ---
/usr/src/sys/modules/drm2/i915kms/../../../dev/drm2/i915/i915_gem_context.c:207:20:
note: previous definition is here
static inline bool is_default_context(struct i915_hw_context *ctx)
                   ^
/usr/src/sys/modules/drm2/i915kms/../../../dev/drm2/i915/i915_gem_context.c:763:12:
error: redefinition of 'create_default_context'
static int create_default_context(struct drm_i915_private *dev_priv)
           ^
/usr/src/sys/modules/drm2/i915kms/../../../dev/drm2/i915/i915_gem_context.c:217:12:
note: previous definition is here
static int create_default_context(struct drm_i915_private *dev_priv)
           ^
/usr/src/sys/modules/drm2/i915kms/../../../dev/drm2/i915/i915_gem_context.c:799:6:
error: redefinition of 'i915_gem_context_init'
void i915_gem_context_init(struct drm_device *dev)



--
Johannes Lundberg
BRILLIANTSERVICE CO., LTD.

On Sat, Sep 13, 2014 at 9:19 PM, Lundberg, Johannes <
johannes at brilliantservice.co.jp> wrote:

> Just to make sure, is this the only patch that needs to be applied and
> should it be applied to a recent unmodified 11-current kernel?
>
> --
> Johannes Lundberg
> BRILLIANTSERVICE CO., LTD.
>
> On Sat, Sep 13, 2014 at 7:59 PM, Jean-Sébastien Pédron <
> dumbbell at freebsd.org> wrote:
>
>> On 13.09.2014 12:53, Lutz Bichler wrote:
>> > Hi,
>>
>> Hi!
>>
>> > is it correct that the successful path in drm_gem_find_ptr does not
>> release
>> > "names->lock"?
>>
>> No, it's incorrect. Good catch!
>>
>> I'll update the patch soon.
>>
>> Thank you :)
>>
>> --
>> Jean-Sébastien Pédron
>>
>>
>

-- 
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
秘密保持について:この電子メールは、名宛人に送信したものであり、秘匿特権の対象となる情報を含んでいます。
もし、名宛人以外の方が受信された場合、このメールの破棄、およびこのメールに関する一切の開示、
複写、配布、その他の利用、または記載内容に基づくいかなる行動もされないようお願い申し上げます。
---
CONFIDENTIALITY NOTE: The information in this email is confidential
and intended solely for the addressee.
Disclosure, copying, distribution or any other action of use of this
email by person other than intended recipient, is prohibited.
If you are not the intended recipient and have received this email in
error, please destroy the original message.


More information about the freebsd-x11 mailing list