Xorg 7.4 crashes on exit

[Robert Noland]

On Wed, 2009-04-01 at 09:09 -0700, Kevin Oberman wrote:
> > From: Robert Noland <rnoland at FreeBSD.org>
> > Date: Tue, 31 Mar 2009 11:49:07 -0500
> > 
> > On Tue, 2009-03-31 at 09:36 -0700, Kevin Oberman wrote:
> > > > Date: Tue, 31 Mar 2009 16:16:57 +0100
> > > > From: "N.J. Mann" <njm at njm.me.uk>
> > > > 
> > > > Hi Robert,
> > > > 
> > > > 
> > > > In message <1238445388.8491.358.camel at balrog.2hip.net>,
> > > > 	Robert Noland (rnoland at FreeBSD.org) wrote:
> > > > > On Mon, 2009-03-30 at 13:11 -0700, Kevin Oberman wrote:
> > > > > > > From: Robert Noland <rnoland at FreeBSD.org>
> > > > > > > Date: Mon, 30 Mar 2009 14:54:45 -0500
> > > > [snip]
> > > > > > > 
> > > > > > > Is this on CURRENT or STABLE and do you know at least approximately when
> > > > > > > you started seeing the issue?
> > > > > > > 
> > > > > > 
> > > > > > It is on stable and I THINK it started when I updated my system to
> > > > > > 7.2-PRERELEASE last week. My previous Stable was on February 7 and it
> > > > > > pre-dated the Xorg-1.5.3 server update on the system.
> > > > > > 
> > > > > > I normally update ports daily, but I did delay the Xorg update for a
> > > > > > week or two to let dust settle.
> > > > > 
> > > > > There are a lot of changed in that window...  I really hope that this
> > > > > doesn't fix it, but could you try reverting:
> > > > > 
> > > > > balrog% svn diff -c r189669
> > > > > Index: drm_drv.c
> > > > > ===================================================================
> > > > > --- drm_drv.c   (revision 189668)
> > > > > +++ drm_drv.c   (revision 189669)
> > > > > @@ -131,7 +131,7 @@
> > > > >         .d_poll =       drm_poll,
> > > > >         .d_mmap =       drm_mmap,
> > > > >         .d_name =       "drm",
> > > > > -       .d_flags =      D_TRACKCLOSE | D_NEEDGIANT
> > > > > +       .d_flags =      D_TRACKCLOSE
> > > > >  };
> > > > >  
> > > > >  static struct drm_msi_blacklist_entry drm_msi_blacklist[] = {
> > > > 
> > > > I was not sure whether you wanted Kevin, me or both of us to try the
> > > > above, so I tried it anyway. :-)  It has no visible affect here at all.
> > > > I double checked I had patched the right file and even re-compiled
> > > > (after doing a rm -rf /usr/obj and a make clean) and re-installed the
> > > > resulting kernel.  No change.
> > > > 
> > > > Are there any debug messages I can enable to help you out here?
> > > 
> > > For me and my Radeon, the change seems to have "fixed" the problem. 
> > > 
> > > I have rebooted several times, including after loading the system with a
> > > variety of graphics oriented tasks (Flash, MPEGs, WMV, ...), I have been
> > > unable to trigger the problem with the NEEDGIANT. I don't have witness
> > > in my kernel and really would have problems with having it there on this
> > > system this week as I am on-call. Yuck!
> > 
> > Ok, could you try removing that and applying this attached change
> > instead:
> > 
> > r190565 | rnoland | 2009-03-30 13:01:42 -0500 (Mon, 30 Mar 2009) | 5
> > lines
> > 
> > We don't know what these pages are going to be used for, they should be
> > un-cached.  This got lost somewhere with all the bus_dma fixups.
> 
> Bingo! No more problems with shutting down X. No GIANT. I like this a LOT
> better.
> 
> Thanks so much.

Ok, cool.  That does give me an idea for the Intel issues as well
maybe...

> Heads up! Now that my ATi problem is resolved, I'll be hitting you with
> the problems I'm having with an nVidia 7800GT. I hope that the nVidia
> issue is "fixable" more readily, though, with config changes rather than
> patches.

I do have patches for nouveau drm. ;)

robert.

-- 
Robert Noland <rnoland at FreeBSD.org>
FreeBSD
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 196 bytes
Desc: This is a digitally signed message part
Url : http://lists.freebsd.org/pipermail/freebsd-x11/attachments/20090402/5d932d65/attachment.pgp