ports/113099: [PATCH] sysutils/libchk may skip $X11BASE now

Akinori MUSHA knu at iDaemons.org
Fri Jun 1 11:21:43 UTC 2007


Hi,

At Wed, 30 May 2007 21:26:58 +0200,
Rene Ladan wrote:
> Dejan Lesjak wrote:
> > USE_NONDEFAULT_X11BASE is only relevant on FreeBSD before 6.2 (as we
> > cant set the default X11BASE in ports infrastructure there). On
> > newer versions one can define different X11BASE even without also
> > setting USE_NONDEFAULT_X11BASE. The ability to do that is left
> > intentionally.
> > Anyhow, perhaps a more general solution for libchk might be to skip
> > $X11BASE if it is the same as $LOCALBASE?
> >
> This sounds reasonable.  Akinori, what do you think of the attached patch?

> +  if $x11base != $localbase
> +    $bindirs += [
> +      "#{$x11base}/bin",
> +      "#{$x11base}/libexec",
> +      "#{$x11base}/sbin",
> +    ]
> +  end

I suppose this would not make any difference to the behavior, since
duplicated or redundant directories (descendant of another entry,
etc.) are removed in compact_dirs!().

The real problem might be that in that process libchk does not use
realpath(3) to follow symlinks but just performs static, literal
string matching.

So if you have /usr/X11R6 symlinked to /usr/local, libchk will dive
into the directory twice.

Regards,

--
                     /
                    /__  __            Akinori.org / MUSHA.org
                   / )  )  ) )  /     FreeBSD.org / Ruby-lang.org
Akinori MUSHA aka / (_ /  ( (__(  @ iDaemons.org / and.or.jp

"Different eyes see different things,
    Different hearts beat on different strings --
       But there are times for you and me when all such things agree"
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 187 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/freebsd-x11/attachments/20070601/403da1d0/attachment.pgp


More information about the freebsd-x11 mailing list