[Fwd: sysutils/libchk: Ignore locations under /usr/X11R6]

[Tom McLaughlin]

On Sat, 2007-07-07 at 21:39 +0200, Rene Ladan wrote: 
> Hi,
> 
> This request to skip $X11BASE in the sysutils/libchk port is similar to 
> ports/113099
> 
> Is it ok / politically correct to approve it?
> 
> Regards,
> Rene
> 

The last patch in PR 113099 doesn't prevent descending into /usr/local
twice when /usr/X11R6 is a symlink to it which is why I sent my PR.  My
patch unfortunately breaks when /usr/X11R6 actually exists and doesn't
even allow you to add it as an extra path on the commandline.  I would
go with whatever Akinori feels is best which looks like checking the
realpath of X11BASE.  I don't know ruby so...

tom

> -------- Originele bericht --------
> Onderwerp: sysutils/libchk: Ignore locations under /usr/X11R6
> Datum: Wed, 4 Jul 2007 21:28:38 -0400
> Van: Tom McLaughlin <tmclaugh at FreeBSD.org>
> Aan: FreeBSD gnats submit <FreeBSD-gnats-submit at FreeBSD.org>
> CC: r.c.ladan at gmail.com
> 
> 
> >Submitter-Id:	current-users 
> >Originator:	Tom McLaughlin 
> >Organization:	 
> >Confidential:	no 
> >Synopsis:	sysutils/libchk: Ignore locations under /usr/X11R6 
> >Severity:	non-critical 
> >Priority:	low 
> >Category:	ports 
> >Class:		change-request 
> >Release:	FreeBSD 6.2-STABLE i386 
> >Environment:
> 
> 
> System: FreeBSD 6.2-STABLE #0: Tue Jun 19 03:46:08 EDT 2007
>      tom at bofh:/usr/obj/usr/src/sys/GENERIC_ULE
> 
> 
> 
> >Description:
> 
> 
> Attached patch causes libchk to ignore the following directories 
> automatically since
> they are really locations under /usr/local now.
> 
> /usr/X11R6/bin
> /usr/X11R6/lib
> /usr/X11R6/libexec
> /usr/X11R6/sbin
> 
> Man page is also updated.
> 
> 
> >How-To-Repeat:
> 
> 
> 
> 
> 
> >Fix:
> 
> 
> --- patch-libchk.rb begins here ---
> --- libchk.rb.orig	Fri May 14 13:11:09 2004
> +++ libchk.rb	Wed Jul  4 19:32:11 2007
> @@ -60,7 +60,12 @@
>       "#{$x11base}/sbin",
>     ]
> 
> -  $exclude_dirs = []
> +  $exclude_dirs = [
> +    "#{$x11base}/bin",
> +    "#{$x11base}/lib",
> +    "#{$x11base}/libexec",
> +    "#{$x11base}/sbin",
> +  ]
>   end
> 
>   def main(argv)
> --- patch-libchk.rb ends here ---
> --- patch-libchk.1 begins here ---
> --- libchk.1.orig	Sun May  2 14:56:10 2004
> +++ libchk.1	Wed Jul  4 19:17:13 2007
> @@ -37,9 +37,6 @@
>   .It Pa $LOCALBASE/bin
>   .It Pa $LOCALBASE/libexec
>   .It Pa $LOCALBASE/sbin
> -.It Pa $X11BASE/bin
> -.It Pa $X11BASE/libexec
> -.It Pa $X11BASE/sbin
>   .El
>   .Pp
>   And the directories listed in
> @@ -123,9 +120,6 @@
>   .It Ev LOCALBASE
>   The local base directory. (default:
>   .Pa /usr/local )
> -.It Ev X11BASE
> -The X11 base directory. (default:
> -.Pa /usr/X11R6 )
>   .El
>   .Sh SEE ALSO
>   .Xr ldconfig 8
> --- patch-libchk.1 ends here ---
> 
> 
> 
> 
> 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 187 bytes
Desc: This is a digitally signed message part
Url : http://lists.freebsd.org/pipermail/freebsd-x11/attachments/20070707/53f9de86/attachment.pgp