Upgrade script

[Kris Kennaway]

On Sun, Apr 15, 2007 at 04:10:46AM +0200, Dejan Lesjak wrote:
> On Sunday 15 April 2007 03:39:22 Kris Kennaway wrote:
> > One more thing I spotted is that it doesn't handle
> > non-default X11BASE or LOCALBASE.  Probably the way to do this is to
> > use
> >
> > PORTSDIR?=/usr/ports
> > X11BASE=`make -f ${PORTSDIR}/Mk/bsd.port.mk -V X11BASE`
> >
> > or similar.  Using bsd.port.mk is so it picks up the default value,
> > and includes /etc/make.conf to check for override.  It also DTRT if
> > X11BASE is set in the environment.
> 
> Hmm. I wouldn't use too much automagic in that case. I'm not sure it's good to 
> assume that if someone has changed the defaults that this script will do the 
> right thing for them regardless if it properly detects changed 
> X11BASE/LOCALBASE. I'd rather say they can change variables at beginning of 
> the script. Perhaps printing the message saying that this should be changed 
> if using non-default (and also to change BACKUPDIR) and then ask for 
> confirmation to continue?

Yes, that is probably best.

Kris

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 187 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/freebsd-x11/attachments/20070415/9632a731/attachment.pgp