change to /usr/include/osreldate.h breaks ports x11-servers/xorg-server

[Eric Anholt]

On Tue, 2005-09-13 at 15:29 -0700, Ted Faber wrote:
> Hi, guys.
> 
> I don't know if you noticed this, but there was a recent commit to
> src/include/Makefile (cvs version 1.247) that changed the generated file
> /usr/include/osreldate.h by adding a prototype for the function
> getosreldate().
> 
> This breaks compilation of x11-servers/xorg-server and I would guess a
> bunch of other X ports.  In x11-servers/xorg-server the problem is that
> config/cf/FreeBSD.cf includes that file, apparently assuming that
> everything in it is a C preprocessor directive.  The new prototype
> results in Makefile.proto files that make does not accept in various
> places in the config directories during make config of the port.
> 
> This seems a little complex for me to produce a patch for.  You all may
> have to negotiate with the committers to remove the prototype or to add
> more complexity to the X configuration stuff to filter that prototype
> out.  Not a decision I'm comfortable suggesting a path for.
> 
> I'm happy to provide more info if you need it.

Sigh.  Imake is such a lame hack.

I think the best solution here will be to just use the major/minor
versions instead of osreldate and not worry about fine-grained feature
addition on (old) -current/-stable in the imake case.

-- 
Eric Anholt                                     eta at lclark.edu
http://people.freebsd.org/~anholt/              anholt at FreeBSD.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 187 bytes
Desc: This is a digitally signed message part
Url : http://lists.freebsd.org/pipermail/freebsd-x11/attachments/20050913/9be7134c/attachment.bin