ports/76257: nvidia_driver breaks xorg-clients build

[FelixKühling]

Am Dienstag, den 22.02.2005, 00:08 -0500 schrieb Mikhail Teterin:
> > Could you try if the attached patch against xdriinfo.c works with
> > NVidia's GLX? If it does, then I'll commit this to Xorg CVS.
> 
> Using glXGetProcAddressARB instead of glXGetProcAddress allows the
> utility to build, but it still does not work -- the calls return NULL at
> run-time.
> 
> If your program only works with Xorg's GLX, than, indeed, the error
> message may need to become more informative.

It was already changed in my patch. Do you have any better suggestions?

> 
> If, on the other hand, using the glXGetProcAddressARB works when linked
> with Xorg's GLX -- why bother with the #ifdefs at all? Just use the old
> call for the time being. :-)

As I mentioned in an earlier mail, the GLX headers from Xorg don't seem
to define the ARB function any more.

> 
> 	-mi
> 
> > --- ./xdriinfo.c.~1.1.3.1.~	2004-06-16 11:27:39.000000000 +0200
> > +++ ./xdriinfo.c	2005-02-21 22:50:37.000000000 +0100
> > @@ -28,6 +28,14 @@
> >  #include <unistd.h>
> >  #include <string.h>
> >  
> > +#ifdef GLX_VERSION_1_4
> > +#   define GLX_GET_PROC_ADDRESS(name) \
> > +        glXGetProcAddress((const GLubyte *)(name))
> > +#else
> > +#   define GLX_GET_PROC_ADDRESS(name) \
> > +        glXGetProcAddressARB((const GLubyte *)(name))
> > +#endif
> > +
> >  typedef const char * glXGetScreenDriver_t (Display *dpy, int scrNum);
> >  typedef const char * glXGetDriverConfig_t (const char *driverName);
> >  
> > @@ -57,10 +65,13 @@
> 
-- 
| Felix Kühling <fxkuehl at gmx.de>                     http://fxk.de.vu |
| PGP Fingerprint: 6A3C 9566 5B30 DDED 73C3  B152 151C 5CC1 D888 E595 |