ports/55699: [PATCH] making x11-servers/XFree86-4-Server able to use mga hal library

[Andre Albsmeier]

The following reply was made to PR ports/55699; it has been noted by GNATS.

From: Andre Albsmeier <andre.albsmeier at siemens.com>
To: freebsd-gnats-submit at FreeBSD.org, rehsack at liwing.de,
	anholt at FreeBSD.org, eta at lclark.edu
Cc:  
Subject: Re: ports/55699: [PATCH] making x11-servers/XFree86-4-Server able to use mga hal library
Date: Fri, 28 Nov 2003 20:10:30 +0100

 The stuff in this PR works great apart from a small bug
 (which is Matrox' fault, not Eric's). I have tested it with
 the DVI-Output of a G550 and the TV-Out of a G400 which both
 need the HAL in order to work.
 
 I have also tested some configurations with the patched
 version of the XFree86-4-Server port but without the HAL
 binary installed. This also works perfectly as long as
 no special HAL features are needed, of course.
 
 Details:
 ========
 
 Tested stuff which needs the HAL:
 ----------------------------------
 G550 with DVI output:		works
 G400 with TV-Out only:		works
 G400 with monitor and TV-Out:	fails, this is the bug
 				mentioned above, fix below
 
 
 Tested stuff without the HAL but the patched XFree86-4-Server port:
 -------------------------------------------------------------------
 G550 with analog screen:	works
 G400 with analog screen:	works
 Millenium 2:			works
 
 
 Now the bug: The patch-mga_hal file contains the modifications of
 the XFree86-4-Server port to "upgrade" the MGA driver to the
 4.3.0 version shipped by Matrox in their mgadrivers-3.0-src.tgz.
 It contains the following change for mga_driver.c:
 
 @@ -2664,7 +2711,7 @@
                 pMga->pMgaModeInfo->ulTVStandard = TV_NTSC;
         }
      } else {
 -       pMga->pMgaModeInfo->ulRefreshRate = 0;
 +       pMga->pMgaModeInfo->ulRefreshRate = 60;
         pMga->pMgaModeInfo->ulTVStandard = TV_NTSC;
      } 
    
 
 (You can find the same change when comparing version 4.2.1
 with 4.3.0 contained in mgadrivers-3.0-src.tgz).
 
 This code seems to be run for every head on the G400 and
 rendered my 1280x1024 screen (attached to the first head)
 unusable due to a vertical refresh head of 51 Hz. I don't
 know why they set the default ulRefreshRate to 60 Hz on a
 non TV screen but after removing this part of the patches
 in patch-mga_hal everything worked again.
 
 	-Andre