www/129144: www/en/multimedia/multimedia.pl - fix SGML markup constraints

Edwin Groothuis edwin at mavetju.org
Mon Nov 24 11:50:05 PST 2008


>Number:         129144
>Category:       www
>Synopsis:       www/en/multimedia/multimedia.pl - fix SGML markup constraints
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-www
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          maintainer-update
>Submitter-Id:   current-users
>Arrival-Date:   Mon Nov 24 19:50:04 UTC 2008
>Closed-Date:
>Last-Modified:
>Originator:     Edwin Groothuis
>Release:        FreeBSD 7.1-BETA i386
>Organization:
-
>Environment:
System: FreeBSD k7.mavetju.org 7.1-BETA FreeBSD 7.1-BETA #0: Sun Sep 7 13:49:18 UTC 2008 root at logan.cse.buffalo.edu:/usr/obj/usr/src/sys/GENERIC i386


>Description:

Please apply this patch to the multimedia resources in the WWW cvs
tree. It is to properly generate the URLs for the EuroBSDCon2008
links. After this is commited, www/129127 can be commited.

>How-To-Repeat:
>Fix:

Index: multimedia.pl
===================================================================
RCS file: /home/dcvs/www/en/multimedia/multimedia.pl,v
retrieving revision 1.3
diff -u -r1.3 multimedia.pl
--- multimedia.pl	12 Jun 2008 19:02:27 -0000	1.3
+++ multimedia.pl	24 Nov 2008 19:39:32 -0000
@@ -262,10 +262,10 @@
 
     print $fhandle "<li><p>";
     if (defined $item{overview}) {
-	print $fhandle "<a href=\"$item{overview}\">$item{title}</a>\n";
+	print $fhandle "<a href=\"", htmlentities($item{overview}), "\">$item{title}</a>\n";
     } else {
 	my %media = %{$item{files}{0}};
-	print $fhandle "<a href=\"$media{url}\">$item{title}</a>\n";
+	print $fhandle "<a href=\"", htmlentities($media{url}), "\">$item{title}</a>\n";
 	if (defined $media{size} || defined $media{length}) {
 	    my $s = "";
 	    print $fhandle "(";
@@ -280,7 +280,7 @@
 	    print $fhandle ")";
 	}
     }
-    print $fhandle "<br>Source: <a href=\"", $source{url}, "\">",
+    print $fhandle "<br>Source: <a href=\"", htmlentities($source{url}), "\">",
 	$source{name}, "</a><br>\n";
     print $fhandle "Added: ",
 	    substr($item{added}, 6, 2), " ",
>Release-Note:
>Audit-Trail:
>Unformatted:


More information about the freebsd-www mailing list