www/79659: cvsweb cannot cope with %

[Dan Langille]

On 8 Apr 2005 at 15:13, Ceri Davies wrote:

> On Fri, Apr 08, 2005 at 02:58:29PM +0100, Ceri Davies wrote:
> > On Fri, Apr 08, 2005 at 08:38:42AM -0400, Dan Langille wrote:
> > > On 8 Apr 2005 at 12:24, Ceri Davies wrote:
> > > > On Fri, Apr 08, 2005 at 10:40:09AM +0000, Dan Langille wrote:
> > > > 
> > > > >  Your investigation prompted me to check my local repository which 
> > > > >  uses cvsweb-2.0.6.  cvsweb has no problem with that file.  I see that 
> > > > >  FreeBSD is using FreeBSD-CVSweb 2.0.6.  It has a problem with that 
> > > > >  file.
> > > > >  
> > > > >  This suggests that the problem may not be with cvsweb, but with 
> > > > >  something else.  The error message:
> > > > >  
> > > > >  Bad Request
> > > > >  Your browser sent a request that this server could not understand.
> > > > >  
> > > > >  A grep of the repo projects/cvsweb does not find "Bad Request".  This 
> > > > >  also suggests it could be something other than cvsweb that is 
> > > > >  displaying this message.
> > > > 
> > > > It's Apache.  From the CHANGES file in Apache 0.8.15:
> > > > 
> > > >   *) Reject paths containing %-escaped '%' or null characters [David Robinson]
> > > > 
> > > > Googling seems to suggest that this was done because it was deemed
> > > > forbidden by RFC 2396, which is not the case.
> > > 
> > > Hold on.... why do we see the problem at www.freebsd.org but not on 
> > > my local (private) cvsweb?  I'm running apache-1.3.33_1
> > 
> > Because you are not using mod_rewrite.
> 
> Check it out; with mod_rewrite the % needs escaping twice:
> http://www.freebsd.org/cgi/cvsweb.cgi/ports/devel/gdb6/files/patch-i386%2525nm-fbsd64.h

Oh good!

So this is a cvsweb bug.  Thank you.

Note: escaping the % twice on my system gives:

Error: ports/devel/gdb6/files/patch-i386%25nm-fbsd64.h: no such file 
or directory

So any fix must check for mod_rewrite.

-- 
Dan Langille : http://www.langille.org/
BSDCan - The Technical BSD Conference - http://www.bsdcan.org/
   NEW brochure available at http://www.bsdcan.org/2005/advocacy/