[rft] ar9300 HAL updated

[Raphael Kubo da Costa]

Adrian Chadd <adrian at freebsd.org> writes:

> I've just updated the AR9300 HAL to the March 13 snapshot from QCA.
>
> This includes calibration and TX power calibration changes that may
> improve stability.
>
> As always, it's possible I broke something!
>
> I'd appreciate it if people would test this in STA and AP mode.

I'm at r248944 here using HEAD.

After checking out the code, I created the expected symlinks at the new
contrib/ location (BTW, are you sure you want
sys/contrib/sys/dev/ath instead of sys/contrib/dev/ath, which seems to
be the chosen location for other modules?).

The first error I got was in ar9300_radio.c:90 -- clang complained
`ichan' was not being used.

It is now failing like this:

cc -O2 -pipe -fno-strict-aliasing -Werror -D_KERNEL -DKLD_MODULE -nostdinc  -I. -I/usr/src/sys/modules/ath/../..
/dev/ath -I/usr/src/sys/modules/ath/../../dev/ath/ath_hal -I. -I/usr/src/sys/modules/ath/../../contrib/sys/dev/a
th/ath_hal/ -DHAVE_KERNEL_OPTION_HEADERS -include /usr/obj/usr/src/sys/ORWELL/opt_global.h -I. -I@ -I@/contrib/a
ltq -fno-common -g -fno-omit-frame-pointer -I/usr/obj/usr/src/sys/ORWELL  -mno-aes -mno-avx -mcmodel=kernel -mno
-red-zone -mno-mmx -mno-sse -msoft-float  -fno-asynchronous-unwind-tables -ffreestanding -fstack-protector -std=
iso9899:1999 -Qunused-arguments -fstack-protector -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes
-Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual  -Wundef -Wno-pointer-sign -fformat-extensions  -Wmiss
ing-include-dirs -fdiagnostics-show-option  -Wno-error-tautological-compare -Wno-error-empty-body  -Wno-error-pa
rentheses-equality  -c /usr/src/sys/modules/ath/../../contrib/sys/dev/ath/ath_hal/ar9300/ar9300_eeprom.c
In file included from /usr/src/sys/modules/ath/../../contrib/sys/dev/ath/ath_hal/ar9300/ar9300_eeprom.c:27:
/usr/src/sys/modules/ath/../../contrib/sys/dev/ath/ath_hal/ar9300/ar9300template_generic.h:113:3: error:
      implicit conversion from 'int' to 'u_int8_t' (aka 'unsigned char') changes value from -477 to 35
      [-Werror,-Wconstant-conversion]
                FREQ2FBIN(2412, 1),
                ^~~~~~~~~~~~~~~~~~
/usr/src/sys/modules/ath/../../contrib/sys/dev/ath/ath_hal/ar9300/ar9300eep.h:142:65: note: expanded from macro
      'FREQ2FBIN'
    (((y) == HAL_FREQ_BAND_2GHZ) ? ((x) - 2300) : (((x) - 4800) / 5))
                                                   ~~~~~~~~~~~~~^~~
The error message is repeated multiple times (one for each FREQ2FBIN call).