11s mesh path setup problem

[Monthadar Al Jaberi]

On Mon, Jan 16, 2012 at 9:39 AM, Monthadar Al Jaberi
<monthadar at gmail.com> wrote:
> On Wed, Jan 11, 2012 at 8:03 PM, Bernhard Schmidt <bschmidt at freebsd.org> wrote:
>> On Wednesday 11 January 2012 18:23:29 Adrian Chadd wrote:
>>> Hi!
>>>
>>> I've just done a bit of a code review. Here are my comments:
>
> sorry for late answer here is a a better formated patch.
>
>>>
>>> * ether_sprintf() can't be implemented the way you've implemented it -
>>> it just won't work at all in a multithreaded, concurrent environment.
>>> We'll have to find an alternative way.
>>>
>>> Maybe something like:
>>>
>>> char *
>>> ether_sprintf2(const u_char *ap, char *buf, int len)
>>> {
>>>     .. do things to buf, rather than the static buf.
>>> }
>>>
>>> Then maybe this'd work:
>>>
>>> char a[32], b[32];
>>> IEEE80211_NOTE(..., ether_sprintf2(addr1, a, 32), ether_sprintf2(addr2, a, 32));
>>>
>>> does that make sense?
>>
>> Isn't there an example in net80211 with %D?
>> printf("%6D %6D", addr1, ":", addr2, ":");

Ok here is a patch just for fixing ieee80211_hwmp IEEE80211_NOTE
function calls before my patch.
does it look okej?

>>
>> The saner alternative is to call printf() multiple times, see ieee80211_dump_pkt() as an example.
>
> But that means we have to modify for example ieee80211_note_mac function?
>
>>
>> --
>> Bernhard
>
>
>
> --
> Monthadar Al Jaberi



-- 
Monthadar Al Jaberi
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ieee80211_note_format.patch
Type: text/x-patch
Size: 8424 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/freebsd-wireless/attachments/20120116/cfdcc528/ieee80211_note_format.bin