kern/162475: [ath] functions with return type HAL_BOOL (might) return HAL_STATUS

Alexander Best arundel at freebsd.org
Sat Dec 3 14:00:25 UTC 2011


The following reply was made to PR kern/162475; it has been noted by GNATS.

From: Alexander Best <arundel at freebsd.org>
To: bug-followup at freebsd.org
Cc:  
Subject: Re: kern/162475: [ath] functions with return type HAL_BOOL (might) return HAL_STATUS
Date: Sat, 3 Dec 2011 13:55:34 +0000

 here are two more examples:
 
 /usr/subversion-src/sys/dev/an/if_an.c:800:41: warning: implicit conversion from enumeration type 'enum ieee80211_phytype' to different enumeration type 'enum ieee80211_phymode' [-Wconversion]
                 mword = ieee80211_rate2media(NULL, r, IEEE80211_T_DS);
                         ~~~~~~~~~~~~~~~~~~~~          ^~~~~~~~~~~~~~
 /usr/subversion-src/sys/dev/an/if_an.c:3302:30: warning: implicit conversion from enumeration type 'enum ieee80211_phytype' to different enumeration type 'enum ieee80211_phymode' [-Wconversion]
                 status.an_current_tx_rate, IEEE80211_T_DS);
                                            ^~~~~~~~~~~~~~
 2 warnings generated.
 
 ..also fixing these would make the entire kernel code "-Wconversion"-clean, i believe.
 
 cheers.
 alex


More information about the freebsd-wireless mailing list