comparing floating points via "==" or "!="

Alexander Best arundel at freebsd.org
Thu Dec 1 00:11:58 UTC 2011


On Thu Dec  1 11, Igor Mozolevsky wrote:
> On 1 December 2011 00:02, Alexander Best <arundel at freebsd.org> wrote:
> > On Wed Nov 30 11, Igor Mozolevsky wrote:
> >> On 30 November 2011 22:44, Alexander Best <arundel at freebsd.org> wrote:
> >>
> >> > i played a bit with the gcc -Wfloat-equal warning and noticed that inside
> >> > sys/dev/ath/ath_rate/sample/tx_schedules.h, a lot of comparisons of floating
> >> > points are happening ("=="). is there a better way to deal with this?
> >>
> >> as opposed to (abs(a-b) < tolerance)?
> >
> > fabs(3) actually, or some other way, e.g. described in:
> 
> I thought from the context it was fairly clear that the appropriate
> XabsY variant had to be used without me being unnecessarily verbose in
> mentioning fabs(), and its fabsl() and fabsf() friends?..

i sorry. since sys/dev/ath/ath_rate/sample/tx_schedules.h also handles a lot
of integer values, i thought you referred to abs(3), because you saw also
some issues with the integer computations in that file. so i thought you were
referring to yet another issue in that file.

cheers.
alex

> 
> 
> Cheers,
> 
> --
> Igor ;-)


More information about the freebsd-wireless mailing list