[Bug 168298] VirtualBox using AIO on a zvol crashes

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=168298

--- Comment #50 from Tom Rushworth <tbr at acm.org> ---
(In reply to Pete French from comment #48)

Thanks for the "nice job" :).

Yes this should go upstream, it is not FreeBSD specific.  As far as I could see
by grepping through the entire source tree, no platform looks at the AIO limit
after obtaining it.  That's OK when the platform doesn't have a limit :).

I've never contacted the VBox folks, does someone who has contacted them want
to volunteer to pass the information on?

I'd also like to repeat that the patch is pretty ugly, look at the number of
data structures that have to be gone through to get the AIO limit when making
the decision to grow.  The upstream folks should have a much better way to
actually fix things, such as copying the AIO limit to the AIO manager when the
manager is created so it is easier to get at when the decision needs to be
made.  I just made the patch as small and localized as possible to reduce the
risk of breaking things I didn't understand :).

-- 
You are receiving this mail because:
You are the assignee for the bug.