Rework hypervisor detection

[Jung-uk Kim]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 2014-10-27 13:16:45 -0400, Jung-uk Kim wrote:
2014년 10월 27일 13:16에 Jung-uk Kim 이(가) 쓴 글:> On 2014-10-27
12:47:13 -0400, Conrad Meyer wrote:
>> Hi John,
> 
>> I don't have access to phabricator so I'll try and review in 
>> email.
> 
>>> +#ifdef XEN +int vm_guest = VM_GUEST_XEN; +#else +int vm_guest
>>> = VM_GUEST_NO; /* Running as virtual machine guest? */ +#endif
> 
>> The whitespace between 'int' and 'vm_guest' in the second line 
>> seems wrong (extra space?).
> 
>> For vmware_hvcall() in x86/include/vmware.h, are you sure the 
>> inline assembly is correct? Have you tried the detection on a 
>> VMware VM? VMware's documentation specifies the arguments in a 
>> different order[0], and at Isilon when we tried the port-based 
>> detection in a slightly older revision of CURRENT, it didn't
>> work (IIRC).
> 
>> Everything else looks good to me, thanks.
> 
>> [0]: 
>> http://kb.vmware.com/selfservice/microsites/search.do?language=en_US&cmd=displayKC&externalId=1009458
>
>> 
> I wrote the code and it worked for me at the time.  I'll try again
> soon.

I just tested the function and it still works well.

Jung-uk Kim
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQEcBAEBAgAGBQJUTo9cAAoJEHyflib82/FGLOAIAJYFN2KVlaLgmVTtOX5uU/yf
gjazSIRLzQopS/yMUDvZ0hSJovoqFtHpUHTWwIMhqbpKD0u2OehTVWrt+frYrrG1
R0DHlWXIeBkfgdp3fD/6jW5Bbq1yNidn6arquSbbhxLROOTkuE0jiHUHYhgkD89a
ZluWuHfuNCPrAYEfLKAOs739ocQO+xZe+jeS2lae74bSgE06kRnQgx72Cv7ZZU35
l3C152sJKuDR+P9DOxi/mLdWcNXO76YFXkmt2JvIey2FUsw3fCIYXbN0FOz/dWD6
q8DaSCWjxYHs1TLPCueBrOgOyIzDQ5Ky4l1V/8aBROigtgmVsxv0U/rKZO5pSSs=
=dG0n
-----END PGP SIGNATURE-----