why does ulpt depend on ucom?

[Carl]

On 2011-03-01 12:46 AM, Hans Petter Selasky wrote:
> On Tuesday 01 March 2011 09:33:38 Hans Petter Selasky wrote:
>> On Tuesday 01 March 2011 07:31:00 Daniel O'Connor wrote:
>>> On 01/03/2011, at 15:52, Carl wrote:
>>>> /usr/src/sys/conf/files causes the ucom driver to be compiled into the
>>>> kernel if ulpt is specified for inclusion. Why? ucom provides support
>>>> for USB tty.
>>>
>>> Looks like a bug, specifically the second to last line of
>>> /usr/src/sys/dev/usb/serial/ulpt.c
>>
>> You are right.
>>
>>> Also, I'm not really sure why ulpt.c is in the serial directory but that
>>> isn't a big issue.

It's not going to affect anyone very much, but it seems to me that it 
should be moved since it's rather misleading.

> Please try the attached patch and report back.

The kernels I'm building all require ucom for other reasons and don't 
include ulpt, so that patch wouldn't get tested by my builds. Hopefully 
someone else can test your patch.

I spotted the issue only because I was trying to figure out how ucom 
gets into the GENERIC kernel despite the lack of "device ucom" appearing 
anywhere in the kernel configuration file. There are no less than 13 
different man pages that incorrectly state that "device ucom" is 
necessary even though /usr/src/sys/conf/files makes that untrue. Since I 
didn't know about /usr/src/sys/conf/files before, it took me a while to 
figure out how ucom was getting included in apparent contradiction to 
the documentation.

The wrong man pages:

# find /usr/src -name '*.4' -exec grep -H 'device ucom' {} \; | grep -v 
'/ucom.4'
/usr/src/share/man/man4/u3g.4:.Cd "device ucom"
/usr/src/share/man/man4/uark.4:.Cd "device ucom"
/usr/src/share/man/man4/ubsa.4:.Cd "device ucom"
/usr/src/share/man/man4/uchcom.4:.Cd "device ucom"
/usr/src/share/man/man4/ufoma.4:.Cd "device ucom"
/usr/src/share/man/man4/uftdi.4:.Cd "device ucom"
/usr/src/share/man/man4/uipaq.4:.Cd "device ucom"
/usr/src/share/man/man4/umct.4:.Cd "device ucom"
/usr/src/share/man/man4/umodem.4:.Cd "device ucom"
/usr/src/share/man/man4/uplcom.4:.Cd "device ucom"
/usr/src/share/man/man4/uslcom.4:.Cd "device ucom"
/usr/src/share/man/man4/uvisor.4:.Cd "device ucom"
/usr/src/share/man/man4/uvscom.4:.Cd "device ucom"

BTW, am I missing something or is there truly no documentation for the 
format of /usr/src/sys/conf.files?

Hans, do I need to submit bug reports for any of these things or will 
you just be checking in all the necessary fixes?

Carl                                                   / K0802647