usb/130230: [patch] [quirk] [usb67] [usb] [cam] [umass] Samsung Electronics YP-U3 does not attach in 7.1-RELEASE

[Alexander Best]

The following reply was made to PR usb/130230; it has been noted by GNATS.

From: Alexander Best <arundel at freebsd.org>
To: bug-followup at freebsd.org
Cc:  
Subject: usb/130230: [patch] [quirk] [usb67] [usb] [cam] [umass] Samsung Electronics YP-U3 does not attach in 7.1-RELEASE
Date: Sat, 13 Nov 2010 14:03:15 +0000

 --Nq2Wo0NMKNjxTN9z
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: inline
 
 could you please try the first patch and see if that lets you use your device
 without any manual quirks?
 
 if that works it would be nice if you could also try the second patch. maybe
 the existing scsi quirks aren't necessary anymore. this is just a guess
 however. if your device stops working after you've applied the second patch,
 please revert it and only use the first patch.
 
 cheers.
 alex
 
 -- 
 a13x
 
 --Nq2Wo0NMKNjxTN9z
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: attachment; filename="yp-u3.diff1"
 
 diff --git a/sys/dev/usb/quirk/usb_quirk.c b/sys/dev/usb/quirk/usb_quirk.c
 index 6691538..15611c3 100644
 --- a/sys/dev/usb/quirk/usb_quirk.c
 +++ b/sys/dev/usb/quirk/usb_quirk.c
 @@ -332,6 +332,8 @@ static struct usb_quirk_entry usb_quirks[USB_DEV_QUIRKS_MAX] = {
  	USB_QUIRK_VP(USB_VENDOR_SAMSUNG_TECHWIN,
  	    USB_PRODUCT_SAMSUNG_TECHWIN_DIGIMAX_410, UQ_MSC_FORCE_WIRE_BBB,
  	    UQ_MSC_FORCE_PROTO_SCSI, UQ_MSC_NO_INQUIRY),
 +	USB_QUIRK(SAMSUNG, YP_U3, 0x0000, 0xffff, UQ_MSC_NO_INQUIRY,
 +	    UQ_MSC_NO_SYNC_CACHE),
  	USB_QUIRK(SAMSUNG, YP_U4, 0x0000, 0xffff, UQ_MSC_NO_SYNC_CACHE),
  	USB_QUIRK(SANDISK, SDDR05A, 0x0000, 0xffff, UQ_MSC_FORCE_WIRE_CBI,
  	    UQ_MSC_FORCE_PROTO_SCSI, UQ_MSC_READ_CAP_OFFBY1,
 diff --git a/sys/dev/usb/usbdevs b/sys/dev/usb/usbdevs
 index 404ec18..dc92093 100644
 --- a/sys/dev/usb/usbdevs
 +++ b/sys/dev/usb/usbdevs
 @@ -2773,6 +2773,7 @@ product SAGEM XG76NA		0x0062	XG-76NA
  /* Samsung products */
  product SAMSUNG ML6060		0x3008	ML-6060 laser printer
  product SAMSUNG YP_U2		0x5050	YP-U2 MP3 Player
 +product SAMSUNG YP_U3		0x507c	YP-U3 MP3 Player
  product SAMSUNG YP_U4		0x5092	YP-U4 MP3 Player
  product SAMSUNG I500		0x6601	I500 Palm USB Phone
  product SAMSUNG I330		0x8001	I330 phone cradle
 
 --Nq2Wo0NMKNjxTN9z
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: attachment; filename="yp-u3.diff2"
 
 diff --git a/sys/cam/scsi/scsi_da.c b/sys/cam/scsi/scsi_da.c
 index b3b968c..29e1641 100644
 --- a/sys/cam/scsi/scsi_da.c
 +++ b/sys/cam/scsi/scsi_da.c
 @@ -545,14 +545,6 @@ static struct da_quirk_entry da_quirk_table[] =
  		 "*"}, /*quirks*/ DA_Q_NO_SYNC_CACHE
  	},
  	{
 -		/*
 -		 * Samsung YP-U3 mp3-player
 -		 * PR: 125398
 -		 */
 -		{T_DIRECT, SIP_MEDIA_REMOVABLE, "Samsung", "YP-U3",
 -		 "*"}, /*quirks*/ DA_Q_NO_SYNC_CACHE
 -	},
 -	{
  		{T_DIRECT, SIP_MEDIA_REMOVABLE, "Netac", "OnlyDisk*",
  		 "2000"}, /*quirks*/ DA_Q_NO_SYNC_CACHE
  	},
 
 --Nq2Wo0NMKNjxTN9z--