usb/144423: if_run panic with USB-N13

[PseudoCylon]

The following reply was made to PR usb/144423; it has been noted by GNATS.

From: PseudoCylon <moonlightakkiy at yahoo.ca>
To: Hans Petter Selasky <hselasky at c2i.net>
Cc: bug-followup at freebsd.org, jhanna at pangolin-systems.com,
  freebsd-usb at freebsd.org, freebsd-gnats-submit at freebsd.org
Subject: Re: usb/144423: if_run panic with USB-N13
Date: Fri, 5 Mar 2010 05:12:24 -0800 (PST)

 --0-1892306353-1267794744=:21252
 Content-Type: text/plain; charset=us-ascii
 
 
 
 ----- Original Message ----
 > From: Hans Petter Selasky <hselasky at c2i.net>
 > To: PseudoCylon <moonlightakkiy at yahoo.ca>
 > Cc: bug-followup at freebsd.org; jhanna at pangolin-systems.com; freebsd-usb at freebsd.org; freebsd-gnats-submit at freebsd.org
 > Sent: Fri, March 5, 2010 5:14:24 AM
 > Subject: Re: usb/144423: if_run panic with USB-N13
 > 
 > On Friday 05 March 2010 12:40:05 PseudoCylon wrote:
 > > ----- Original Message ----
 > > 
 > > > From: Hans Petter Selasky 
 > > > To: PseudoCylon 
 > > > Cc: bug-followup at freebsd.org; jhanna at pangolin-systems.com;
 > > > freebsd-usb at freebsd.org; freebsd-gnats-submit at freebsd.org Sent: Fri,
 > > > March 5, 2010 2:42:41 AM
 > > > Subject: Re: usb/144423: if_run panic with USB-N13
 > > >
 > > > On Friday 05 March 2010 10:31:35 PseudoCylon wrote:
 > > > > >The files seem a little far from the current I am running, I just used
 > > > > >the updates to the usbdevs file and the unlock-lock around the
 > > > > > firmware load in if_run.c.
 > > > >
 > > > > Yes, there are some bits added to support RT3572 chipsets. It would be
 > > > >  greately appreciated if you try that file if it's not too mutch
 > > > > trouble.
 > > > >
 > > > > >The ASUS-N13 does work when a child wlan device is created with it,
 > > > > >but if just "ifconfig run0 up" is done there is a page fault. I do
 > > > > >not know if that is expected. This occurs with or without runfw.ko
 > > > > >being loaded beforehand.
 > > > >
 > > > > Yes, "ifconfig run0 up" will cause page fault. The wlanN interface is
 > > > >  should be created as an instance of the parent interface and used for
 > > > >  actual communication. This is new feature to 8.0 and 9-current. My
 > > > >  understanding is that if you create wlan and "ifconfig *wlan0* up", it
 > > > >  works, but if you "ifconfig *run0* up", it causes panic. (Of cource
 > > > >  without *. I'm trying to enphasize the point in plain text messeage.)
 > > > > That is what should happen. (Actually, result of "ifconfig *run0* up"
 > > > > is undefined.) "run0" should only be used when creating wlan.
 > > > >
 > > > > If "ifconfig *wlan0* ..." is causing problem, please let us know.
 > > >
 > > > What is the backtrace of the panic?
 > > 
 > > KDB: stack backtrace:
 > > db_trace_self_wrapper() at db_trace_self_wrapper+0x2a
 > > _witness_debugger() at _witness_debugger+0x2e
 > > witness_warn() at witness_warn+0x2c2
 > > trap() at trap+0x2f5
 > > calltrap() at calltrap+0x8
 > > --- trap 0xc, rip = 0xffffffff80c5cfd7, rsp = 0xffffff8021f76880, rbp =
 > >  0xffffff8021f768c0 --- run_stop() at run_stop+0x67
 > > run_init_locked() at run_init_locked+0x33
 > > run_ioctl() at run_ioctl+0xad
 > > ifioctl() at ifioctl+0xde4
 > > kern_ioctl() at kern_ioctl+0xc5
 > > ioctl() at ioctl+0xf0
 > > syscall() at syscall+0x1af
 > > Xfast_syscall() at Xfast_syscall+0xe1
 > > --- syscall (54, FreeBSD ELF64, ioctl), rip = 0x800b8286c, rsp =
 > >  0x7fffffffe2f8, rbp = 0x7fffffffe300 ---
 > > 
 > > There are number of places refers uninitialized value in run_stop() and
 > >  run_init() if vap hasn't created, so it will cause page fault. I can move
 > >  those instructions to other places (maybe vap_delete). It won't panic but
 > >  device won't work without vap.
 > > 
 > 
 > Can't you add a NULL pointer check?
 > 
 > It should not panic.
 > 
 > --HPS
 
 Yes. I moved draintask functions to vap_delete like other driver. some are still in run_stop() with NULL ptr check. patch is against rev. 7
 
 Device doesn't work with "ifconfig run0" but it won't panic at least. "ifconfig run0 scan" gives "unable to get scan result" And. I'm sending this mail with wlan0.
 
 AK
 
 
       __________________________________________________________________
 Looking for the perfect gift? Give the gift of Flickr! 
 
 http://www.flickr.com/gift/
 --0-1892306353-1267794744=:21252
 Content-Type: application/octet-stream; name="if_run.patch"
 Content-Transfer-Encoding: base64
 Content-Disposition: attachment; filename="if_run.patch"
 
 KioqIG9sZC9pZl9ydW4uYwkyMDEwLTAzLTA1IDA1OjQ2OjM0LjAwMDAwMDAw
 MCAtMDcwMAotLS0gbmV3L2lmX3J1bi5jCTIwMTAtMDMtMDUgMDU6NDg6MDcu
 MDAwMDAwMDAwIC0wNzAwCioqKioqKioqKioqKioqKgoqKiogNzg3LDc5MyAq
 KioqCiAgCiEgCWlmIChpZnAgJiYgaWZwLT5pZl9mbGFncyAmIElGRl9VUCl7
 CiEgCQlSVU5fTE9DSyhzYyk7CiEgCQlydW5fc3RvcChzYyk7CiEgCQlSVU5f
 VU5MT0NLKHNjKTsKISAJfQogIAotLS0gNzg3LDc5NyAtLS0tCiAgCiEgCVJV
 Tl9MT0NLKHNjKTsKISAJc2MtPnNjX3J2cC0+YW1ycl9ydW4gPSBSVU5fQU1S
 Ul9PRkY7CiEgCVJVTl9VTkxPQ0soc2MpOwohIAohIAkvKiBkcmFpbiB0aGVt
 IGFsbCAqLwohIAl1c2JfY2FsbG91dF9kcmFpbigmc2MtPnNjX3J2cC0+YW1y
 cl9jaCk7CiEgCWllZWU4MDIxMV9kcmFpbnRhc2soaWMsICZzYy0+c2NfcnZw
 LT5hbXJyX3Rhc2spOwohIAlpZWVlODAyMTFfZHJhaW50YXNrKGljLCAmc2Mt
 PndtZV90YXNrKTsKISAJaWVlZTgwMjExX2RyYWludGFzayhpYywgJnNjLT51
 c2JfdGltZW91dF90YXNrKTsKICAKKioqKioqKioqKioqKioqCioqKiA0MjM2
 LDQyMzggKioqKgogIAlzdHJ1Y3QgaWVlZTgwMjExY29tICppYyA9IGlmcC0+
 aWZfbDJjb207Ci0gCXN0cnVjdCBpZWVlODAyMTF2YXAgKnZhcCA9ICZzYy0+
 c2NfcnZwLT52YXA7CiAgCXVpbnQzMl90IHRtcDsKLS0tIDQyNDAsNDI0MSAt
 LS0tCioqKioqKioqKioqKioqKgoqKiogNDM5Myw0Mzk1ICoqKioKICAJLyog
 c2VsZWN0IGRlZmF1bHQgY2hhbm5lbCAqLwotIAl2YXAtPml2X2Jzcy0+bmlf
 Y2hhbiA9IGljLT5pY19jdXJjaGFuOwkvKiBpY19ic3NjaGFuPz8gKi8KICAJ
 cnVuX3NldF9jaGFuKHNjLCBpYy0+aWNfY3VyY2hhbik7Ci0tLSA0Mzk2LDQz
 OTcgLS0tLQoqKioqKioqKioqKioqKioKKioqIDQ0NDYsNDQ0OSAqKioqCiAg
 CiEgCWlmIChpYy0+aWNfZmxhZ3MgJiBJRUVFODAyMTFfRl9TQ0FOKQohIAkJ
 aWVlZTgwMjExX2NhbmNlbF9zY2FuKCZzYy0+c2NfcnZwLT52YXApOwogIAot
 LS0gNDQ0OCw0NDU0IC0tLS0KICAKISAJaWYoc2MtPnNjX3J2cCAhPSBOVUxM
 KXsKISAJCXNjLT5zY19ydnAtPmFtcnJfcnVuID0gUlVOX0FNUlJfT0ZGOwoh
 IAkJaWYgKGljLT5pY19mbGFncyAmIElFRUU4MDIxMV9GX1NDQU4pCiEgCQkJ
 aWVlZTgwMjExX2NhbmNlbF9zY2FuKCZzYy0+c2NfcnZwLT52YXApOwohIAl9
 CiAgCioqKioqKioqKioqKioqKgoqKiogNDQ1NCw0NDY2ICoqKioKICAKLSAJ
 c2MtPnNjX3J2cC0+YW1ycl9ydW4gPSBSVU5fQU1SUl9PRkY7Ci0gCiAgCVJV
 Tl9VTkxPQ0soc2MpOwogIAotIAkvKiBkcmFpbiB0aGVtIGFsbCAqLwotIAl1
 c2JfY2FsbG91dF9kcmFpbigmc2MtPnNjX3J2cC0+YW1ycl9jaCk7Ci0gCWll
 ZWU4MDIxMV9kcmFpbnRhc2soaWMsICZzYy0+c2NfcnZwLT5hbXJyX3Rhc2sp
 OwotIAlpZWVlODAyMTFfZHJhaW50YXNrKGljLCAmc2MtPndtZV90YXNrKTsK
 ICAJZm9yKGkgPSAwOyBpIDwgUlVOX05fWEZFUjsgaSsrKQogIAkJdXNiZF90
 cmFuc2Zlcl9kcmFpbihzYy0+c2NfeGZlcltpXSk7Ci0gCWllZWU4MDIxMV9k
 cmFpbnRhc2soaWMsICZzYy0+dXNiX3RpbWVvdXRfdGFzayk7CiAgCi0tLSA0
 NDU5LDQ0NjQgLS0tLQo=
 
 --0-1892306353-1267794744=:21252--