usb/134193: System freeze on usb MP3 player insertion

[Henri-Pierre Charles]

>Number:         134193
>Category:       usb
>Synopsis:       System freeze on usb MP3 player insertion
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-usb
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sun May 03 20:00:07 UTC 2009
>Closed-Date:
>Last-Modified:
>Originator:     Henri-Pierre Charles
>Release:        7-2-PRERELEASE
>Organization:
>Environment:
FreeBSD asus.hpch.net 7.2-PRERELEASE FreeBSD 7.2-PRERELEASE #3: Sun May  3 17:23:24 CEST 2009     root at media.hpch.net:/usr/src/sys/i386/compile/GENERIC  i386

>Description:
Using an MP3 player (MPMAN model) the system freeze and give this message :

May  2 21:31:24 media kernel: umass0: BBB reset failed, TIMEOUT
May  2 21:31:24 media kernel: umass0: BBB bulk-in clear stall failed, TIMEOUT
May  2 21:31:24 media kernel: umass0: BBB bulk-out clear stall failed, TIMEOUT
May  2 21:31:24 media kernel: umass0: BBB reset failed, TIMEOUT

It's impossible to use the system, and of course the MP3 player.
>How-To-Repeat:
Insert a MPMAN player. I've tried with different model (1Go and 2 Go)
>Fix:
Patching sys/dev/usb/usbdevs for adding name for this device and patching sys/dev/usb/umass.c for adding quirk NO_SYNCHRONIZE_CACHE fixe the problem

Patch attached with submission follows:

*** usbdevs	2009-04-15 05:14:26.000000000 +0200
--- usbdevs.hpc	2009-05-03 17:58:53.000000000 +0200
***************
*** 1,4 ****
! $FreeBSD: src/sys/dev/usb/usbdevs,v 1.328.2.26.2.1 2009/04/15 03:14:26 kensmith Exp $
  /* $NetBSD: usbdevs,v 1.392 2004/12/29 08:38:44 imp Exp $ */
  
  /*-
--- 1,4 ----
! $FreeBSD: src/sys/dev/usb/usbdevs,v 1.328.2.26 2009/03/23 04:06:21 thompsa Exp $
  /* $NetBSD: usbdevs,v 1.392 2004/12/29 08:38:44 imp Exp $ */
  
  /*-
***************
*** 624,629 ****
--- 624,630 ----
  vendor LINKSYS3		0x1915	Linksys
  vendor QUALCOMMINC	0x19d2	Qualcomm, Incorporated
  vendor STELERA		0x1a8d	Stelera Wireless
+ vendor MPMAN		0x1cae	MpMan
  vendor DRESDENELEKTRONIK 0x1cf1 dresden elektronik
  vendor DLINK		0x2001	D-Link
  vendor PLANEX2		0x2019	Planex Communications
***************
*** 663,668 ****
--- 664,673 ----
   * List of known products.  Grouped by vendor.
   */
  
+ /* MpMan products */
+ product MPMAN MPF400_1		0x36d0  MPF400 Music Player 1Go
+ product MPMAN MPF400_2		0x25a8  MPF400 Music Player 2Go
+ 
  /* 3Com products */
  product 3COM HOMECONN		0x009d	HomeConnect Camera
  product 3COM 3CREB96		0x00a0	Bluetooth USB Adapter
*** umass.c	2009-04-15 05:14:26.000000000 +0200
--- umass.c.hpc	2009-05-03 17:58:33.000000000 +0200
***************
*** 24,30 ****
   * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
   * SUCH DAMAGE.
   *
!  *	$FreeBSD: src/sys/dev/usb/umass.c,v 1.160.2.7.2.1 2009/04/15 03:14:26 kensmith Exp $
   *	$NetBSD: umass.c,v 1.28 2000/04/02 23:46:53 augustss Exp $
   */
  
--- 24,30 ----
   * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
   * SUCH DAMAGE.
   *
!  *	$FreeBSD: src/sys/dev/usb/umass.c,v 1.160.2.7 2009/03/23 18:13:18 thompsa Exp $
   *	$NetBSD: umass.c,v 1.28 2000/04/02 23:46:53 augustss Exp $
   */
  
***************
*** 332,337 ****
--- 332,341 ----
  };
  
  static struct umass_devdescr_t umass_devdescrs[] = {
+   	{ USB_VENDOR_MPMAN, PID_WILDCARD,  RID_WILDCARD,
+ 	  UMASS_PROTO_SCSI | UMASS_PROTO_BBB,
+ 	  NO_SYNCHRONIZE_CACHE
+ 	},
  	{ USB_VENDOR_ADDONICS2, USB_PRODUCT_ADDONICS2_CABLE_205, RID_WILDCARD,
  	  UMASS_PROTO_SCSI | UMASS_PROTO_BBB,
  	  NO_QUIRKS


>Release-Note:
>Audit-Trail:
>Unformatted: