USB support in NDIS -- IFF_NEEDSGIANT?

[Hans Petter Selasky]

On Friday 13 March 2009, Robert Watson wrote:
> On Tue, 17 Feb 2009, Weongyo Jeong wrote:
> >> As you know, I've been gradually working to eliminate all non-MPSAFE
> >> network device driver infrastructure for 8.0, having removed non-MPSAFE
> >> network protocol infrastructure in 7.0.  In reviewing remaining drivers
> >> using IFF_NEEDSGIANT, I spotted this in the NDIS code:
>
> ...
>
> >> Having taken a glance, it looks like this was added specifically to
> >> support USB devices attached via NDIS.
> >
> > AFAIK all of usb wireless drivers had it so I couldn't avoid it when I
> > had implemented.
> >
> >> With the new USB code, are NDIS drivers still supported?
> >
> > I think that it would be supported at 8.0
> >
> >> And in the new world order, is this IFF_NEEDSGIANT still required?
> >
> > Probably we can remove the IFF_NEEDSGIANT flags at the new USB code.
> >
> >> Can I simply remove it once the old USB code is on the way out the door?
> >
> > IMHO yes I think.
>
> Dear all:
>
> A few weeks have passed, so I wanted to check in and see how this project
> was going -- are we at a point yet where removing IFF_NEEDSGIANT won't
> cause significant loss of functionality?

I think both NDIS USB and USB Ethernet/WLAN drivers have been made Giant-free.

--HPS