[SOLVED] Re: Problem with usb4bsd rev566

[Stefan Lambrev]

Hi Hans,

Thanks for your response.
I'm little puzzled right now :)

I'm looking at i4b/trunk/i4b/src/sys/dev/usb/usb_transfer.c
The logic in rev 566 in case 4 is to call
                usbd_callback_wrapper(xfer[0], info, USBD_CONTEXT_CALLBACK);
                usbd_callback_wrapper(xfer[1], info, USBD_CONTEXT_CALLBACK);
                usbd_callback_wrapper(xfer[2], info, USBD_CONTEXT_CALLBACK);
                usbd_callback_wrapper(xfer[3], info, USBD_CONTEXT_CALLBACK);

not just: usbd_callback_wrapper(xfer[3], info, USBD_CONTEXT_CALLBACK);

Am I right?

If yes please consider the attached patch (the patch is against rev 566) 
- it will
remove lockcheck_0/1 lables, all "goto" to them and uint8_t dropcount; 
is not not needed (less needed memory?)

Also for i4b/trunk/i4b/src/sys/dev/usb/usb_port.h
#define thread_lock(td) mtx_lock_spin(&sched_lock)
#define thread_unlock(td) mtx_unlock_spin(&sched_lock)

Those should not be defined as they are already defined in 
sys/sys/mutex.h - Revision 1.96 (which is part of RELENG_7 and RELENG_7_0)
and the code will not compile, thus the need of special case for 
versions >= 700000 and < 800000

Hans Petter Selasky wrote:
> Hi Stefan,
>
> Your patches have been committed with some modifications. Please check if the 
> code compiles now. Thanks for reporting!
>
> --HPS
>   

-- 

Best Wishes,
Stefan Lambrev
ICQ# 24134177

-------------- next part --------------
A non-text attachment was scrubbed...
Name: usb_transfer.c.new.diff
Type: text/x-patch
Size: 2802 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/freebsd-usb/attachments/20080115/9881fb28/usb_transfer.c.new.bin