if_ural.c in FreeBSD 7-current

[Hans Petter Selasky]

Hi,

Can someone answer me quick on this one:

In FreeBSD 7-current, I think I see some mistakes in "if_ural.c".

For example:

> #define URAL_RSSI(rssi)                                       \
>       ((rssi) > (RAL_NOISE_FLOOR + RAL_RSSI_CORR) ?   \
>        ((rssi) - RAL_NOISE_FLOOR + RAL_RSSI_CORR) : 0)


Should there be a parenthesis here ??

> #define URAL_RSSI(rssi)                                       \
>       ((rssi) > (RAL_NOISE_FLOOR + RAL_RSSI_CORR) ?   \
>        ((rssi) - (RAL_NOISE_FLOOR + RAL_RSSI_CORR)) : 0)

Also I see that the basic rate set is set multiple times:

By "set_chan" and when the RUN state is entered! This does not make sense!

--HPS