usb/118915: usbhidctl appears to not report features and write size correctly

[Maurice Castro]

>Number:         118915
>Category:       usb
>Synopsis:       usbhidctl appears to not report features and write size correctly
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    freebsd-usb
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri Dec 21 02:40:00 UTC 2007
>Closed-Date:
>Last-Modified:
>Originator:     Maurice Castro
>Release:        FreeBSD 6.2-RELEASE i386
>Organization:
>Environment:
System: FreeBSD atum.castro.aus.net 6.2-RELEASE FreeBSD 6.2-RELEASE #3: Fri Nov 9 12:40:40 EST 2007 root at atum2.castro.aus.net:/usr/src/sys/i386/compile/ATUM i386

	FreeBSD all versions

>Description:
	system utility usbhidctl does not use hid_report_size as per 
	documentation (arguments 2 and 3 are transposed) appears to 
	report incorrect values in output
>How-To-Repeat:
	
>Fix:

--- /usr/src/usr.bin/usbhidctl/usbhid.c	Mon May 26 14:58:26 2003
+++ ./usbhid.c	Fri Dec 21 13:12:08 2007
@@ -148,13 +148,13 @@
 		}
 	}
 	hid_end_parse(d);
-	size = hid_report_size(r, 0, hid_input);
+	size = hid_report_size(r, hid_input, 0);
 	printf("Total   input size %d bytes\n", size);
 
-	size = hid_report_size(r, 0, hid_output);
+	size = hid_report_size(r, hid_output, 0);
 	printf("Total  output size %d bytes\n", size);
 
-	size = hid_report_size(r, 0, hid_feature);
+	size = hid_report_size(r, hid_feature, 0);
 	printf("Total feature size %d bytes\n", size);
 }
 


>Release-Note:
>Audit-Trail:
>Unformatted: