[brooks@freebsd.org: PERFORCE change 89882 for review]

[Brooks Davis]

Any objections to the following patch?  It adds the ability to add a
quirk that affects all devices from a particular vendor, adds the vendor
Phidgets Inc., and blacklists all of their devices in the HID driver.
In this case, the vendor provides a libusb based API (a port of which
I'll commit soon) that won't work if uhid(4) binds the devices.  If they
ever release a device that should actually attach as a HID device, we
can add the dozen or so entries that need to be blacklisted directly,
but for now it seems pointless and even unproductive.

-- Brooks

----- Forwarded message from Brooks Davis <brooks at freebsd.org> -----

From: Brooks Davis <brooks at freebsd.org>
Date: Wed, 18 Jan 2006 01:27:40 GMT
To: Perforce Change Reviews <perforce at freebsd.org>
Subject: PERFORCE change 89882 for review

http://perforce.freebsd.org/chv.cgi?CH=89882

Change 89882 by brooks at brooks_pagefault on 2006/01/18 01:26:52

	Add a vendor entry for Phidgets Inc and add all their products
	to the HID blacklist.  All their currently supported products
	are supported by a libusb based driver which does not work if
	uhid(4) binds to the device.

Affected files ...

.. //depot/user/brooks/cleanup/sys/dev/usb/usb_quirks.c#11 edit
.. //depot/user/brooks/cleanup/sys/dev/usb/usbdevs#47 edit

Differences ...

==== //depot/user/brooks/cleanup/sys/dev/usb/usb_quirks.c#11 (text+ko) ====

@@ -110,6 +110,8 @@
 	ANY, { UQ_HID_IGNORE }},
  { USB_VENDOR_MGE, USB_PRODUCT_MGE_UPS2,
 	ANY, { UQ_HID_IGNORE }},
+ { USB_VENDOR_PHIDGETS, ANY,
+	ANY, { UQ_HID_IGNORE }},
  { 0, 0, 0, { 0 } }
 };
 
@@ -125,7 +127,7 @@
 
 	for (t = usb_quirks; t->idVendor != 0; t++) {
 		if (t->idVendor  == vendor &&
-		    t->idProduct == product &&
+		    (t->idProduct == ANY || t->idProduct == product) &&
 		    (t->bcdDevice == ANY || t->bcdDevice == revision))
 			break;
 	}

==== //depot/user/brooks/cleanup/sys/dev/usb/usbdevs#47 (text+ko) ====

@@ -333,6 +333,7 @@
 vendor ALCATELT		0x06b9	Alcatel
 vendor AGFA		0x06bd	AGFA-Gevaert
 vendor ASIAMD		0x06be	Asia Microelectronic Development
+vendor PHIDGETS		0x06c2	Phidgets Inc.
 vendor BIZLINK		0x06c4	Bizlink
 vendor KEYSPAN		0x06cd	Keyspan / InnoSys Inc.
 vendor AASHIMA		0x06d6	Aashima

----- End forwarded message -----
-- 
Any statement of the form "X is the one, true Y" is FALSE.
PGP fingerprint 655D 519C 26A7 82E7 2529  9BF0 5D8E 8BE9 F238 1AD4
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/freebsd-usb/attachments/20060117/e40aaed0/attachment.bin