PATCH: NO_GETMAXLUN quirk was ignored

Matt Reimer mattjreimer at gmail.com
Wed Nov 23 10:45:53 PST 2005


I noticed that several devices define NO_GETMAXLUN quirks but this quirk is
never consulted by the umass driver. The following patch seems to work. Is
what was really intended?

Matt

--- umass.c     Wed Nov 23 10:43:00 2005
+++ umass.c.new Wed Nov 23 10:00:51 2005
@@ -1094,7 +1094,8 @@ USB_ATTACH(umass)

        /* Get the maximum LUN supported by the device.
         */
-       if ((sc->proto & UMASS_PROTO_WIRE) == UMASS_PROTO_BBB)
+       if (((sc->proto & UMASS_PROTO_WIRE) == UMASS_PROTO_BBB) &&
+           !(sc->quirks & NO_GETMAXLUN))
                sc->maxlun = umass_bbb_get_max_lun(sc);
        else
                sc->maxlun = 0;


More information about the freebsd-usb mailing list