recent USB MFCs cause panics

[Helge Oldach]

Julian,

> maybe the answer is to comment out
> 
>         DEVMETHOD(bus_child_detached, uhub_child_detached),
> 
> at line 134 of uhub.c
>     DEVMETHOD(bus_child_detached, uhub_child_detached),
> It's kind of hard for me to...... (sudden thought appears)

Did comment that line out. Precisely:

--- uhub.c.ctm  Wed May  4 15:58:48 2005
+++ uhub.c      Tue May 10 21:27:38 2005
@@ -131,7 +131,7 @@
 #else
 USB_DECLARE_DRIVER_INIT(uhub,
        DEVMETHOD(bus_driver_added, uhub_driver_added),
-       DEVMETHOD(bus_child_detached, uhub_child_detached),
+       /* DEVMETHOD(bus_child_detached, uhub_child_detached), */
        DEVMETHOD(device_suspend, bus_generic_suspend),
        DEVMETHOD(device_resume, bus_generic_resume),
        DEVMETHOD(device_shutdown, bus_generic_shutdown)

But the result is still the same:

umass0: BBB bulk-in clear stall failed, STALLED
umass0: BBB bulk-out clear stall failed, STALLED
umass0: BBB reset failed, STALLED
umass0: BBB bulk-in clear stall failed, STALLED
umass0: BBB bulk-out clear stall failed, STALLED
umass0: BBB reset failed, STALLED
umass0: at uhub1 port 2 (addr 5) disconnected
umass0: detached
(null): BBB bulk-in clear stall failed, CANCELLED
(null): BBB bulk-out clear stall failed, CANCELLED
panic: (null): Unknown state 0

> DUH you are running this in a hub aren't you?

Yes:

uhub1: Cypress Semiconductor Slim Hub, class 9/0, rev 2.00/0.08, addr 3
uhub1: 4 ports with 4 removable, self powered

I'm now back to the situation before your MFC. That works reliably. I
would suggest to back this out for the time being.

Regards,
Helge