kern/68232: [patch] ugen(4) isochronous handling correction and tx support

Hans Petter Selasky hselasky at c2i.net
Wed Jun 8 16:00:25 GMT 2005


The following reply was made to PR kern/68232; it has been noted by GNATS.

From: Hans Petter Selasky <hselasky at c2i.net>
To: bug-followup at freebsd.org,
 matthew.gream at pobox.com
Cc:  
Subject: Re: kern/68232: [patch] ugen(4) isochronous handling correction and tx support
Date: Wed, 8 Jun 2005 17:54:52 +0200

 Hi,
 
 sce->isorate must be initialized somewhere. 
 Also it must be range checked.
 
 Is USBD_SET_RATE or USBD_GET_RATE documented somewhere.
 I think it is not so smart to pass the total number of 
 bytes per second. What is important is the frame size, 
 to synchronize data. Therefore USBD_SET_FRAME_SIZE and 
 USBD_GET_FRAME_SIZE would be better. And more generic! 
 Can you change this?
 
 Remember there is USB2.0 with 1000*8 frames per second.
 So USBD_SET_RATE might require two different values for 
 the same application, which is not very good.
 
 --HPS


More information about the freebsd-usb mailing list