Please commit fix outlined in PR/63837

[Will Saxon]

> -----Original Message-----
> From: Warner Losh [mailto:imp at bsdimp.com]
> Sent: Friday, April 08, 2005 3:40 PM
> To: Will Saxon
> Cc: usb at FreeBSD.org
> Subject: Re: Please commit fix outlined in PR/63837
> 
> 
> From: "Will Saxon" <WillS at housing.ufl.edu>
> Subject: Please commit fix outlined in PR/63837
> Date: Fri, 8 Apr 2005 15:34:14 -0400
> 
> > Is it possible to get the 1 line fix posted in PR/63837 added 
> > before 5.4? This has been a problem since before 5.3, the fix is 
> > trivial and it works fine.
> > 
> > It is kind of annoying to have to edit hid.c every time I cvsup.
> > 
> > This has been asked about before by myself and others... Is there
> > a stylistic problem or a planned cleanup that has held this back?
> > 
> > --- /usr/src/sys/dev/usb/hid.c.orig  Fri Apr  8 15:26:46 2005
> > +++ /usr/src/sys/dev/usb/hid.c       Fri Apr  8 14:55:01 2005
> > @@ -375,7 +375,7 @@
> > 
> > 	id = 0;
> > 	for (d = hid_start_parse(buf, len, 1<<k); hid_get_item(d, &h); )
> > -		if (h.report_ID != 0)
> > + 		if (h.report_ID != 0 && !id)
> > 			id = h.report_ID;
> > 	hid_end_parse(d);
> > 	size = h.loc.pos;
> 
> So this patch just makes report_ID the FIRST id in the item list,
> right?

Looks like it, although really I haven't the foggiest. I do know that 
without the patch, the mouse included with my MX Duo doesn't work. 
With it, the mouse works. 

Reading through the PR notes, it appears that a) the answer to 
your question is yes and b) the below patch is more of a hack 
that makes things work and that 'this seems to be a horrible 
interface.'

That's fine, but the last message on the PR that was NOT a 'hey this 
works for me too' was mid November. The assertion was that we should 
try to adopt the solution(s) NetBSD has to fix this and other things, 
however I don't think that has happened yet.

It would just be nice to get an update, it would make editing
hid.c less aggravating if I knew for sure it wasn't always going
to be this way. I guess I just forget that I have to do it and then
I get mad when I've built a new kernel and my mouse stops working :).

-Will