Legacy keyboard suppport stops USB from working! (uhci)

[Josef Karthauser]

Do users know that having legacy keyboard/mouse support switched on
in the bios is a sure fire way of causing USB to not work properly?
I wonder whether we would benefit from something like the following
patch.

Joe


Index: uhci_pci.c
===================================================================
RCS file: /home/ncvs/src/sys/dev/usb/uhci_pci.c,v
retrieving revision 1.55
diff -u -r1.55 uhci_pci.c
--- uhci_pci.c	13 Oct 2004 14:51:42 -0000	1.55
+++ uhci_pci.c	10 Nov 2004 11:10:42 -0000
@@ -341,11 +341,12 @@
 	 * that the BIOS won't touch the keyboard anymore if it is connected
 	 * to the ports of the root hub?
 	 */
-#ifdef USB_DEBUG
-	if (pci_read_config(self, PCI_LEGSUP, 2) != PCI_LEGSUP_USBPIRQDEN)
+	if (pci_read_config(self, PCI_LEGSUP, 2) != PCI_LEGSUP_USBPIRQDEN) {
 		device_printf(self, "LegSup = 0x%04x\n",
 		    pci_read_config(self, PCI_LEGSUP, 2));
-#endif
+		device_printf(self, "(If USB doesn't work try disabling "
+		    "legacy keyboard/mouse support in the BIOS)");
+	}
 	pci_write_config(self, PCI_LEGSUP, PCI_LEGSUP_USBPIRQDEN, 2);
 
 	err = uhci_init(sc);

-- 
Josef Karthauser (joe at tao.org.uk)	       http://www.josef-k.net/
FreeBSD (cvs meister, admin and hacker)     http://www.uk.FreeBSD.org/
Physics Particle Theory (student)   http://www.pact.cpes.sussex.ac.uk/
================ An eclectic mix of fact and theory. =================
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/freebsd-usb/attachments/20041110/cffa0087/attachment.bin