[Differential] [Accepted] D1826: libdwarf: Add symbol value when processing .rela relocations
kostikbel (Konstantin Belousov)
phabric-noreply at FreeBSD.org
Wed Feb 11 19:18:46 UTC 2015
kostikbel accepted this revision.
kostikbel added a comment.
This revision is now accepted and ready to land.
It looks fine, but definitely is extremely subtle. The dwarf_get_reloc_size() returns zero for non-abs relocations, so dwarf_write_{m.l}sb() does nothing for other relocation types.
This at least deserves explanation in a comment.
REVISION DETAIL
https://reviews.freebsd.org/D1826
To: emaste, rpaulo, kostikbel
Cc: freebsd-toolchain
More information about the freebsd-toolchain
mailing list