[RFC] adding -Wmissing-include-dirs to CWARNFLAGS

Alexander Best arundel at freebsd.org
Thu Apr 7 18:55:10 UTC 2011


hi there,

i'd like to propose adding -Wmissing-include-dirs to CWARNFLAGS. this will let
tinderbox fail, if any new kernel code was committed with (a) broken include
dir(s).

i ran a test via

make toolchains
make MAKE_JUST_KERNELS=yes tinderbox

and nothing seemed to go wrong with the extra warning enabled. i even found a
missing include dir, which should be fixed by the attached patch.

opinions?

so far i've only tested this with gcc. i think someone on #freebsd-clang told
me that -Wmissing-include-dirs is a noop for clang (for whatever reasons).

cheers.
alex

-- 
a13x
-------------- next part --------------
diff --git a/sys/modules/netgraph/atm/ccatm/Makefile b/sys/modules/netgraph/atm/ccatm/Makefile
index 5626536..8bf741d 100644
--- a/sys/modules/netgraph/atm/ccatm/Makefile
+++ b/sys/modules/netgraph/atm/ccatm/Makefile
@@ -12,6 +12,6 @@ KMOD=	ng_ccatm
 SRCS=	ng_ccatm.c cc_conn.c cc_data.c cc_dump.c cc_port.c cc_sig.c	\
 	cc_user.c unisap.c
 
-CFLAGS+= -I${LIBBASE} -I${LIBBASE}/netnatm/ccatm -DCCATM_DEBUG
+CFLAGS+= -I${LIBBASE} -DCCATM_DEBUG
 
 .include <bsd.kmod.mk>


More information about the freebsd-toolchain mailing list