threads/76938: include/unistd.h: ttyname_r prototype missing

[Robert Watson]

On Fri, 18 Feb 2005, Craig Rodrigues wrote:

> On Fri, Feb 18, 2005 at 03:51:01PM -0500, Daniel Eischen wrote:
> > Style: all returns should be "return (foo)", not "return foo".
> 
> OK, the attached patch fixes this.
> 
> > This may also cause an ABI change since ttyname_r use to
> > return (char *).  I'm not sure of the impact though 'cause
> > it was never in a header file.
> 
> This does change the ABI, but I also don't know what the impact is,
> since this function was not exported from a header file. 
> 
> The old ttyname_r() should have been declared static, since it was never
> exported through a header file, but that's life.  At least the new
> ttyname_r() conforms to SuS, so it has a better chance of working with
> software written on other platforms. 

You might want to ask Kris Kenneway if he could do a scan of the
ports/packages to see what links against the ttyname_r symbol, if
anything.

Robert N M Watson