RFC: getc() and putc() as macros

Peter Wemm peter at wemm.org
Sat Mar 13 16:23:19 PST 2004


On Saturday 13 March 2004 07:05 am, Daniel Eischen wrote:
> On Sat, 13 Mar 2004, Tim Robbins wrote:
> > The patch below re-adds macro versions of getc(), getchar(),
> > putc(), putchar(), feof(), ferror(), fileno() and clearerr(), using
> > the value of __isthreaded to decide between the fast inline
> > single-threaded code and the more general function equivalent (as
> > suggested by Alfred). Is this approach safe?
>
> I don't really like this.  It exposes __isthreaded and others
> that are implementation.

I thought that was the kind of thing that  _REENTRANT or _THREAD_SAFE 
are usually for? (*shudder*)
-- 
Peter Wemm - peter at wemm.org; peter at FreeBSD.org; peter at yahoo-inc.com
"All of this is for nothing if we don't go to the stars" - JMS/B5


More information about the freebsd-threads mailing list